linux-kernel - Re: [PATCH v1 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas panel timing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJpp1ZHFFY9M3i47d658Q-m3ggJzhxSRUapX=tckgdAwcNg@mail.gmail.com>
Date: Mon, 16 Sep 2024 07:11:17 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Zhaoxiong Lv <lvzhaoxiong@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, quic_jesszhan@...cinc.com, sam@...nborg.org, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
	airlied@...il.com, simona@...ll.ch, dianders@...omium.org, hsinyi@...gle.com, 
	awarnecke002@...mail.com, dri-devel@...ts.freedesktop.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas
 panel timing

On Sun, 15 Sept 2024 at 10:10, Zhaoxiong Lv
<lvzhaoxiong@...qin.corp-partner.google.com> wrote:
>
> In order to meet the timing, remove the delay between "backlight off"
> and "display off"
>
> Removing variables: display_off_to_enter_sleep_delay_ms

This is not enough. If this is a fix, then describe why the original
commit is incorrect, provide necessary explanation, details, etc.
Otherwise it looks as if you are removing the delay that was necessary
for other panels

Also if this is a fix, it should be properly notated with the Fixes
tag, maybe cc:stable, etc.

In its current state: NAK.

>
> Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@...qin.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> index 44897e5218a6..2f8af86bc2a0 100644
> --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> @@ -31,7 +31,6 @@ struct jadard_panel_desc {
>         bool reset_before_power_off_vcioo;
>         unsigned int vcioo_to_lp11_delay_ms;
>         unsigned int lp11_to_reset_delay_ms;
> -       unsigned int backlight_off_to_display_off_delay_ms;
>         unsigned int display_off_to_enter_sleep_delay_ms;
>         unsigned int enter_sleep_to_reset_down_delay_ms;
>  };
> @@ -69,9 +68,6 @@ static int jadard_disable(struct drm_panel *panel)
>         struct jadard *jadard = panel_to_jadard(panel);
>         struct mipi_dsi_multi_context dsi_ctx = { .dsi = jadard->dsi };
>
> -       if (jadard->desc->backlight_off_to_display_off_delay_ms)
> -               mipi_dsi_msleep(&dsi_ctx, jadard->desc->backlight_off_to_display_off_delay_ms);
> -
>         mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
>
>         if (jadard->desc->display_off_to_enter_sleep_delay_ms)
> @@ -858,7 +854,6 @@ static const struct jadard_panel_desc kingdisplay_kd101ne3_40ti_desc = {
>         .reset_before_power_off_vcioo = true,
>         .vcioo_to_lp11_delay_ms = 5,
>         .lp11_to_reset_delay_ms = 10,
> -       .backlight_off_to_display_off_delay_ms = 100,
>         .display_off_to_enter_sleep_delay_ms = 50,
>         .enter_sleep_to_reset_down_delay_ms = 100,
>  };
> @@ -1109,7 +1104,6 @@ static const struct jadard_panel_desc melfas_lmfbx101117480_desc = {
>         .reset_before_power_off_vcioo = true,
>         .vcioo_to_lp11_delay_ms = 5,
>         .lp11_to_reset_delay_ms = 10,
> -       .backlight_off_to_display_off_delay_ms = 100,
>         .display_off_to_enter_sleep_delay_ms = 50,
>         .enter_sleep_to_reset_down_delay_ms = 100,
>  };
> --
> 2.17.1
>


-- 
With best wishes
Dmitry