linux-kernel - Re: [PATCH v1 2/2] drm/panel: boe-th101mb31ig002: Modify Starry panel timing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJpqC5tQ45gj8-0bDutinCs7CoxiQVL1EAzwDK9RJTXYMcQ@mail.gmail.com>
Date: Mon, 16 Sep 2024 07:15:03 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Zhaoxiong Lv <lvzhaoxiong@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, quic_jesszhan@...cinc.com, sam@...nborg.org, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
	airlied@...il.com, simona@...ll.ch, dianders@...omium.org, hsinyi@...gle.com, 
	awarnecke002@...mail.com, dri-devel@...ts.freedesktop.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] drm/panel: boe-th101mb31ig002: Modify Starry panel timing

Same comment as the one that I've provided to the other patch, plus:

On Sun, 15 Sept 2024 at 10:11, Zhaoxiong Lv
<lvzhaoxiong@...qin.corp-partner.google.com> wrote:
>
> In order to meet the timing, remove the delay between "backlight off"
> and "display off", and reduce the delay between "display_off" and
> "enter_sleep"

Separate commit, separate _justification_. Why, not what.

>
> Removing variables: display_off_to_enter_sleep_delay_ms

This phrase is useless.

>
> Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@...qin.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
> index 0b87f1e6ecae..c2d0ec199829 100644
> --- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
> +++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
> @@ -29,7 +29,7 @@ struct panel_desc {
>         bool lp11_before_reset;
>         unsigned int vcioo_to_lp11_delay_ms;
>         unsigned int lp11_to_reset_delay_ms;
> -       unsigned int backlight_off_to_display_off_delay_ms;
> +       unsigned int display_off_to_enter_sleep_delay_ms;
>         unsigned int enter_sleep_to_reset_down_delay_ms;
>         unsigned int power_off_delay_ms;
>  };
> @@ -184,12 +184,10 @@ static int boe_th101mb31ig002_disable(struct drm_panel *panel)
>                                                       panel);
>         struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi };
>
> -       if (ctx->desc->backlight_off_to_display_off_delay_ms)
> -               mipi_dsi_msleep(&dsi_ctx, ctx->desc->backlight_off_to_display_off_delay_ms);
> -
>         mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
>
> -       mipi_dsi_msleep(&dsi_ctx, 120);
> +       if (ctx->desc->display_off_to_enter_sleep_delay_ms)
> +               mipi_dsi_msleep(&dsi_ctx, ctx->desc->display_off_to_enter_sleep_delay_ms);
>
>         mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
>
> @@ -275,6 +273,7 @@ static const struct panel_desc boe_th101mb31ig002_desc = {
>                           MIPI_DSI_MODE_NO_EOT_PACKET |
>                           MIPI_DSI_MODE_LPM,
>         .init = boe_th101mb31ig002_enable,
> +       .display_off_to_enter_sleep_delay_ms = 120,
>  };
>
>  static const struct drm_display_mode starry_er88577_default_mode = {
> @@ -302,7 +301,7 @@ static const struct panel_desc starry_er88577_desc = {
>         .lp11_before_reset = true,
>         .vcioo_to_lp11_delay_ms = 5,
>         .lp11_to_reset_delay_ms = 50,
> -       .backlight_off_to_display_off_delay_ms = 100,
> +       .display_off_to_enter_sleep_delay_ms = 50,
>         .enter_sleep_to_reset_down_delay_ms = 100,
>         .power_off_delay_ms = 1000,
>  };
> --
> 2.17.1
>


--
With best wishes
Dmitry