linux-kernel - Re: [PATCH] dmaengine: ep93xx: Fix NULL vs IS_ERR() check in ep93xx_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75639e2d585a2d45e015e80044c0f88a3f5ec3b1.camel@gmail.com>
Date: Mon, 16 Sep 2024 20:32:23 +0200
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>, Vinod Koul
 <vkoul@...nel.org>, Nikita Shubin <nikita.shubin@...uefel.me>, Arnd
 Bergmann <arnd@...db.de>, dmaengine@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: dan.carpenter@...aro.org, kernel-janitors@...r.kernel.org, 
	error27@...il.com
Subject: Re: [PATCH] dmaengine: ep93xx: Fix NULL vs IS_ERR() check in
 ep93xx_dma_probe()

Hi Harshit,

thanks for looking into this!

On Mon, 2024-09-16 at 11:23 -0700, Harshit Mogalapalli wrote:
> ep93xx_dma_of_probe() returns error pointers on error. Change the NULL
> check to IS_ERR() check instead.
> 
> Fixes: 5313a72f7e11 ("dmaengine: cirrus: Convert to DT for Cirrus EP93xx")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>

Dan has already fixed this though:
https://lore.kernel.org/lkml/459a965f-f49c-45b1-8362-5ac27b56f5ff@stanley.mountain/

> ---
> This is based on static analysis with Smatch
> ---
>  drivers/dma/ep93xx_dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index d084bd123c1c..ca86b2b5a913 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -1504,7 +1504,7 @@ static int ep93xx_dma_probe(struct platform_device *pdev)
>  	int ret;
>  
>  	edma = ep93xx_dma_of_probe(pdev);
> -	if (!edma)
> +	if (IS_ERR(edma))
>  		return PTR_ERR(edma);
>  
>  	dma_dev = &edma->dma_dev;

-- 
Alexander Sverdlin.