linux-kernel - Re: [PATCH] dmaengine: ep93xx: Fix NULL vs IS_ERR() check in ep93xx_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c44398d2-8322-4a3e-b7cb-80b40d7cb079@oracle.com>
Date: Tue, 17 Sep 2024 00:04:26 +0530
From: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
To: Alexander Sverdlin <alexander.sverdlin@...il.com>,
        Vinod Koul <vkoul@...nel.org>,
        Nikita Shubin <nikita.shubin@...uefel.me>,
        Arnd Bergmann <arnd@...db.de>, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc: dan.carpenter@...aro.org, kernel-janitors@...r.kernel.org,
        error27@...il.com
Subject: Re: [PATCH] dmaengine: ep93xx: Fix NULL vs IS_ERR() check in
 ep93xx_dma_probe()

Hi Alexander,

On 17/09/24 00:02, Alexander Sverdlin wrote:
> Hi Harshit,
> 
> thanks for looking into this!
> 
> On Mon, 2024-09-16 at 11:23 -0700, Harshit Mogalapalli wrote:
>> ep93xx_dma_of_probe() returns error pointers on error. Change the NULL
>> check to IS_ERR() check instead.
>>
>> Fixes: 5313a72f7e11 ("dmaengine: cirrus: Convert to DT for Cirrus EP93xx")
>> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> 
> Dan has already fixed this though:
> https://lore.kernel.org/lkml/459a965f-f49c-45b1-8362-5ac27b56f5ff@stanley.mountain/
> 

Sorry for the noise, I thought I checked lore before sending, but I didnot.

Regards,
Harshit