linux-kernel - Re: [PATCH v4 1/8] dt-bindings: connector: add GE SUNH hotplug addon connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172656899099.2713363.6775764159513105143.robh@kernel.org>
Date: Tue, 17 Sep 2024 05:29:51 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: Thomas Zimmermann <tzimmermann@...e.de>, 
 David Airlie <airlied@...il.com>, linux-fbdev@...r.kernel.org, 
 Dragan Cvetic <dragan.cvetic@....com>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Neil Armstrong <neil.armstrong@...aro.org>, 
 Derek Kiernan <derek.kiernan@....com>, Maxime Ripard <mripard@...nel.org>, 
 Robert Foss <rfoss@...nel.org>, 
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
 Jingoo Han <jingoohan1@...il.com>, Andrzej Hajda <andrzej.hajda@...el.com>, 
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
 Wolfram Sang <wsa+renesas@...g-engineering.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>, 
 Jonas Karlman <jonas@...boo.se>, linux-kernel@...r.kernel.org, 
 Paul Kocialkowski <contact@...lk.fr>, linux-i2c@...r.kernel.org, 
 dri-devel@...ts.freedesktop.org, Saravana Kannan <saravanak@...gle.com>, 
 Paul Kocialkowski <paul.kocialkowski@...tlin.com>, 
 Daniel Thompson <daniel.thompson@...aro.org>, Helge Deller <deller@....de>, 
 devicetree@...r.kernel.org, "Rafael J. Wysocki" <rafael@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>, Daniel Vetter <daniel@...ll.ch>, 
 Hervé Codina <herve.codina@...tlin.com>, 
 Jernej Skrabec <jernej.skrabec@...il.com>, Lee Jones <lee@...nel.org>, 
 Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v4 1/8] dt-bindings: connector: add GE SUNH hotplug
 addon connector

On Tue, 17 Sep 2024 10:53:05 +0200, Luca Ceresoli wrote:
> Add bindings for the GE SUNH add-on connector. This is a physical,
> hot-pluggable connector that allows to attach and detach at runtime an
> add-on adding peripherals on non-discoverable busses.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> 
> ---
> 
> Changed in v4:
>  - rename 'nobus-devices' to 'devices'
>  - use 'additionalProperties: true' for the 'devices' node (nodes are added
>    by overlays)
>  - document GPIO polarity
>  - add '|' for descriptions to preserve line breaks
>  - remove powergood-gpios (removed in hardware design)
>  - Omit "/" node, not needed and cause of warnings
>  - remove reference to v2 examples from example comment
>  - remove unneeded "addon_connector" label from example
> 
> Changed in v3:
>  - change the layout to only add subnodes, not properties
>  - add the 'nobus-devices' node description to hold devices not on any bus
>  - add 'i2c-*' nodes for the I2C busses, using a i2c-parent phandle
>  - and the 'dsi' node for the DSI bus
>  - move the entire port@1 node to the overlay (not only the remote-endpoint
>    property)
>  - remove the overlay examples (Overlays in examples are not supported)
>  - add more clarifying descriptions and comments for examples
>  - some rewording
> 
> This patch was added in v2.
> ---
>  .../connector/ge,sunh-addon-connector.yaml         | 177 +++++++++++++++++++++
>  MAINTAINERS                                        |   5 +
>  2 files changed, 182 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/connector/ge,sunh-addon-connector.example.dtb: addon-connector: Unevaluated properties are not allowed ('powergood-gpios' was unexpected)
	from schema $id: http://devicetree.org/schemas/connector/ge,sunh-addon-connector.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240917-hotplug-drm-bridge-v4-1-bc4dfee61be6@bootlin.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.