linux-kernel - Re: (subset) [PATCH 1/7] block: change wait on bd_claiming to use a var_waitqueue, not a bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172654281968.102466.6048255578818127232.b4-ty@kernel.dk>
Date: Mon, 16 Sep 2024 21:13:39 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, 
 Linus Torvalds <torvalds@...ux-foundation.org>, NeilBrown <neilb@...e.de>
Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
 linux-block@...r.kernel.org
Subject: Re: (subset) [PATCH 1/7] block: change wait on bd_claiming to use
 a var_waitqueue, not a bit_waitqueue


On Mon, 26 Aug 2024 16:30:58 +1000, NeilBrown wrote:
> bd_prepare_to_claim() waits for a var to change, not for a bit to be
> cleared.
> So change from bit_waitqueue() to __var_waitqueue() and correspondingly
> use wake_up_var().
> This will allow a future patch which change the "bit" function to expect
> an "unsigned long *" instead of "void *".
> 
> [...]

Applied, thanks!

[1/7] block: change wait on bd_claiming to use a var_waitqueue, not a bit_waitqueue
      commit: aa3d8a36780ab568d528348dd8115560f63ea16b

Best regards,
-- 
Jens Axboe