linux-kernel - Re: [PATCH 1/7] block: change wait on bd_claiming to use a var_waitqueue, not a bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <172661004540.17050.6252973409733219343@noble.neil.brown.name>
Date: Wed, 18 Sep 2024 07:54:05 +1000
From: "NeilBrown" <neilb@...e.de>
To: "Jens Axboe" <axboe@...nel.dk>
Cc: "Ingo Molnar" <mingo@...hat.com>, "Peter Zijlstra" <peterz@...radead.org>,
 "Linus Torvalds" <torvalds@...ux-foundation.org>,
 linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-block@...r.kernel.org
Subject: Re: [PATCH 1/7] block: change wait on bd_claiming to use a
 var_waitqueue, not a bit_waitqueue

On Tue, 17 Sep 2024, Jens Axboe wrote:
> On 8/26/24 12:30 AM, NeilBrown wrote:
> > bd_prepare_to_claim() waits for a var to change, not for a bit to be
> > cleared.
> > So change from bit_waitqueue() to __var_waitqueue() and correspondingly
> > use wake_up_var().
> > This will allow a future patch which change the "bit" function to expect
> > an "unsigned long *" instead of "void *".
> 
> Looks fine to me - since this one is separate from the series, I can snag
> it and shove it into the block side so it'll make 6.12-rc1. Then at least
> it won't be a dependency for the rest of the series post that.

Thanks Jens!

NeilBrown