linux-kernel - Re: [PATCH v2] usb: gadget: u_ether: Use __netif_rx() in rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024091735-spoiled-apache-6ca1@gregkh>
Date: Tue, 17 Sep 2024 14:09:46 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Hubert Wiśniewski <hubert.wisniewski.25632@...il.com>
Cc: Ferry Toth <ftoth@...londelft.nl>, Kees Cook <kees@...nel.org>,
	Justin Stitt <justinstitt@...gle.com>,
	Richard Acayan <mailingradian@...il.com>,
	"Ricardo B. Marliere" <ricardo@...liere.net>,
	Hardik Gajjar <hgajjar@...adit-jv.com>,
	Jeff Johnson <quic_jjohnson@...cinc.com>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Toke Høiland-Jørgensen <toke@...hat.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: gadget: u_ether: Use __netif_rx() in
 rx_callback()

On Tue, Sep 17, 2024 at 01:19:25PM +0200, Hubert Wiśniewski wrote:
> netif_rx() now disables bottom halves, which causes the USB gadget to be
> unable to receive frames if the interface is not brought up quickly enough
> after being created by the driver (a bug confirmed on AM3352 SoC).
> 
> Replacing netif_rx() with __netif_rx() restores the old behavior and fixes
> the bug. This can be done since rx_callback() is called from the interrupt
> context.
> 
> Fixes: baebdf48c360 ("net: dev: Makes sure netif_rx() can be invoked in any context.")
> Signed-off-by: Hubert Wiśniewski <hubert.wisniewski.25632@...il.com>
> ---
> v1 -> v2: Added Fixes tag and corrected Signed-off-by tag
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot