linux-kernel - Re: [PATCH v2] usb: gadget: u_ether: Use __netif_rx() in rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240917143335.YO5zm3JG@linutronix.de>
Date: Tue, 17 Sep 2024 16:33:35 +0200
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Hubert Wiśniewski <hubert.wisniewski.25632@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ferry Toth <ftoth@...londelft.nl>, Kees Cook <kees@...nel.org>,
	Justin Stitt <justinstitt@...gle.com>,
	Richard Acayan <mailingradian@...il.com>,
	"Ricardo B. Marliere" <ricardo@...liere.net>,
	Hardik Gajjar <hgajjar@...adit-jv.com>,
	Jeff Johnson <quic_jjohnson@...cinc.com>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Toke Høiland-Jørgensen <toke@...hat.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: gadget: u_ether: Use __netif_rx() in
 rx_callback()

On 2024-09-17 13:19:25 [+0200], Hubert Wiśniewski wrote:
> netif_rx() now disables bottom halves, which causes the USB gadget to be
> unable to receive frames if the interface is not brought up quickly enough
> after being created by the driver (a bug confirmed on AM3352 SoC).
> 
> Replacing netif_rx() with __netif_rx() restores the old behavior and fixes
> the bug. This can be done since rx_callback() is called from the interrupt
> context.
> 
> Fixes: baebdf48c360 ("net: dev: Makes sure netif_rx() can be invoked in any context.")
> Signed-off-by: Hubert Wiśniewski <hubert.wisniewski.25632@...il.com>

This does not look right.
Can you add a backtrace and check with lockdep enabled?
netif_rx() should not disable BH if invoked from an interrupt.


Sebastian