lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cf53cbb5-104b-4f60-8890-98a53c27d176@kernel.org>
Date: Tue, 17 Sep 2024 18:59:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jianping.Shen@...bosch.com, jic23@...nel.org, lars@...afoo.de,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 dima.fedrau@...il.com, marcelo.schmitt1@...il.com,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Christian.Lorenz3@...bosch.com,
 Ulrike.Frauendorf@...bosch.com, Kai.Dolde@...bosch.com
Subject: Re: [PATCH v7 0/2] iio: imu: smi240: add bosch smi240 driver

On 13/09/2024 12:00, Jianping.Shen@...bosch.com wrote:
> From: Shen Jianping <Jianping.Shen@...bosch.com>
> 
> Add the iio driver for bosch imu smi240. The smi240 is a combined
> three axis angular rate and three axis acceleration sensor module
> with a measurement range of +/-300°/s and up to 16g. This driver
> provides raw data access for each axis through sysfs, and tiggered
> buffer for continuous sampling. A synchronous acc and gyro sampling
> can be triggered by setting the capture bit in spi read command.
> 
> dt-bindings: 
> v1 -> v2
>     - Add more detail in description
>     - Add maintainer
>     - Add vdd and vddio power supply
>     - Use generic node name
>     - Order the properties according to DTS coding style
> 
> v2 -> v3
>     - Improve description
>     - Improve supply definition
>     - Make supply definition as required
>     - Add supply definition in example
> 
> v3 -> v4
>     - No changes
> 
> v4 -> v5
>     - No changes
> 
> v5 -> v6
>     - Fix checkpatch findings
> 
> v6 -> v7
>     - No changes
> 
> imu driver:
> v1 -> v2
>     - Use regmap for register access
>     - Redefine channel for each singel axis
>     - Provide triggered buffer
>     - Fix findings in Kconfig
>     - Remove unimportant functions
> 
> v2 -> v3
>     - Use enum für capture mode
>     - Using spi default init value instead manual init 
>     - remove duplicated module declaration
>     - Fix code to avoid warning
> 
> v3 -> v4
>     - Use DMA safe buffer
>     - Use channel info instead of custom ABI
>     - Fix other findings
> 
> v4 -> v5
>     - Merge the implementation in one simple file
>     - Add channel info for acc/gyro data channel
>     - Fix other findings

?

> 
> v5 -> v6
>     - Fix checkpatch findings
>     - Fix review findings

? What exactly happened? Your changelog is way too vague.

What happened with our reviews? Why did you get multiple of them?

Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ