[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240917-frail-caboose-772b9818b0ac@squawk>
Date: Tue, 17 Sep 2024 21:42:53 +0100
From: Conor Dooley <conor@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Jianping.Shen@...bosch.com, jic23@...nel.org, lars@...afoo.de,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
dima.fedrau@...il.com, marcelo.schmitt1@...il.com,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Christian.Lorenz3@...bosch.com,
Ulrike.Frauendorf@...bosch.com, Kai.Dolde@...bosch.com
Subject: Re: [PATCH v7 1/2] dt-bindings: iio: imu: smi240: add Bosch smi240
On Tue, Sep 17, 2024 at 06:58:24PM +0200, Krzysztof Kozlowski wrote:
> On 13/09/2024 19:54, Conor Dooley wrote:
> > On Fri, Sep 13, 2024 at 12:00:10PM +0200, Jianping.Shen@...bosch.com wrote:
> >> From: Shen Jianping <Jianping.Shen@...bosch.com>
> >>
> >> add devicetree binding for Bosch imu smi240.
> >> The smi240 is a combined three axis angular rate and
> >> three axis acceleration sensor module.
> >>
> >> * The smi240 requires VDD and VDDIO
> >> * Provides only spi interface.
> >>
> >> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> >
> > 3 reviews? Doing well for yourself!
>
> There is certainly mess here, but that's correct. We both reviewed older
> version and then new version was posted ignoring our tags. So Rob gave
> review.
>
> Changelog is so vague that I have no clue...
Yeah, I figured something like that had happened. Just a tongue-in-cheek
comment ;)
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists