linux-kernel - Re: [PATCH v2] arm64: dts: qcom: x1e80100-t14s: add another trackpad support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5932fc68-3afd-448b-99b8-65ee9ef5dda6@kernel.org>
Date: Wed, 18 Sep 2024 01:32:34 +0200
From: Konrad Dybcio <konradybcio@...nel.org>
To: srinivas.kandagatla@...aro.org, andersson@...nel.org
Cc: konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 abel.vesa@...aro.org
Subject: Re: [PATCH v2] arm64: dts: qcom: x1e80100-t14s: add another trackpad
 support

On 17.09.2024 5:00 PM, srinivas.kandagatla@...aro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> Trackpad HID device on some of the T14s Product Models 21N2ZC5PUS is
> at I2C address 0x2c add this to be able to get it working on these laptops.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
> Changes since v1:
> - moved pinctrl to parent node so that pinctrl can be claimed globally.
> 
>  .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts  | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> index 08ec2419f95f..45a77c1fb6f4 100644
> --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> @@ -551,6 +551,9 @@ zap-shader {
>  &i2c0 {
>  	clock-frequency = <400000>;
>  
> +	pinctrl-0 = <&tpad_default>;
> +	pinctrl-names = "default";

You're dropping the QUP pins, please include them too (like in c630.dtsi)

Konrad