linux-kernel - Re: [PATCH v2] arm64: dts: qcom: x1e80100-t14s: add another trackpad support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZuqdaOSGeReeWNnV@hovoldconsulting.com>
Date: Wed, 18 Sep 2024 11:29:12 +0200
From: Johan Hovold <johan@...nel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc: andersson@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	abel.vesa@...aro.org
Subject: Re: [PATCH v2] arm64: dts: qcom: x1e80100-t14s: add another trackpad
 support

On Wed, Sep 18, 2024 at 01:32:34AM +0200, Konrad Dybcio wrote:
> On 17.09.2024 5:00 PM, srinivas.kandagatla@...aro.org wrote:
> > From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> > 
> > Trackpad HID device on some of the T14s Product Models 21N2ZC5PUS is
> > at I2C address 0x2c add this to be able to get it working on these laptops.
> > 
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> > ---
> > Changes since v1:
> > - moved pinctrl to parent node so that pinctrl can be claimed globally.

> >  &i2c0 {
> >  	clock-frequency = <400000>;
> >  
> > +	pinctrl-0 = <&tpad_default>;
> > +	pinctrl-names = "default";
> 
> You're dropping the QUP pins, please include them too (like in c630.dtsi)

And make sure to CC people that provide feedback on your patches when
respinning.

Johan