linux-kernel - Re: [PATCH v2 1/3] dt-bindings: trivial-devices: support pmbus compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f76798ea-6edd-4888-8057-c09aaed88f25@roeck-us.net>
Date: Wed, 18 Sep 2024 09:53:09 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>, patrick@...cx.xyz,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>, Joel Stanley
 <joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>,
 Noah Wang <noahwang.wang@...look.com>, Peter Yin
 <peteryin.openbmc@...il.com>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Fabio Estevam <festevam@...il.com>, Lukas Wunner <lukas@...ner.de>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH v2 1/3] dt-bindings: trivial-devices: support pmbus
 compatible string

On 9/18/24 06:03, Krzysztof Kozlowski wrote:
> On 18/09/2024 11:54, Delphine CC Chiu wrote:
>> From: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>
>>
>> Add pmbus compatibale string for the Generic PMbus devices that could
>> be monitor by pmbus driver.
>>
> 
> You need to explain more, provide background why we would like to accept
> a generic compatible. And why a specific compatible cannot or should not
> be used...
> 
> In general this is a no, you cannot have such compatibles for real hardware.
> 

Agreed; affected chips should be listed explicitly in drivers/hwmon/pmbus/pmbus.c.

Guenter