linux-kernel - Re: [PATCH 0/4] Add support for new IMX8MP based board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172667917680.1807230.4131958018210713774.robh@kernel.org>
Date: Wed, 18 Sep 2024 12:06:58 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Michal Vokáč <michal.vokac@...ft.com>
Cc: Alexander Stein <alexander.stein@...tq-group.com>, 
 linux-arm-kernel@...ts.infradead.org, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Petr Benes <petr.benes@...ft.com>, 
 Hiago De Franco <hiago.franco@...adex.com>, 
 Pengutronix Kernel Team <kernel@...gutronix.de>, 
 Mathieu Othacehe <m.othacehe@...il.com>, linux-kernel@...r.kernel.org, 
 devicetree@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Shawn Guo <shawnguo@...nel.org>, linux-usb@...r.kernel.org, 
 Joao Paulo Goncalves <joao.goncalves@...adex.com>, 
 Sascha Hauer <s.hauer@...gutronix.de>, Michael Walle <mwalle@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>, Fabio Estevam <festevam@...il.com>, 
 Herburger <gregor.herburger@...tq-group.com>, 
 Hugo Villeneuve <hvilleneuve@...onoff.com>, imx@...ts.linux.dev
Subject: Re: [PATCH 0/4] Add support for new IMX8MP based board


On Tue, 17 Sep 2024 17:09:57 +0200, Michal Vokáč wrote:
> Hi,
> 
> this series adds support for a new member in our IOTA platform.
> The board is based on the i.MX8MP SoC. The first two patches
> add support for most of the board functionality except USB Type-C
> port and some other minor things.
> 
> [PATCH 3] adds new device tree binding for a Diodes Incorporated
> PI5USB30213A Type-C Controller and [PATCH 4] enables that port on
> the IOTA2 Lumpy board.
> 
> We also wrote a driver for that Type-C port controller. I would like
> to get that driver upstream as well but I expect it will take much
> more iterations and effort to get it into mainline-ready shape so
> I intentionally excluded it from this series. AFAIK it should not
> be a problem to accept a device tree binding for a HW that does not
> have a driver in the kernel yet.
> 
> Michal Vokáč (2):
>   dt-bindings: arm: Add i.MX8MP IOTA2 Lumpy board
>   arm64: dts: imx: Add imx8mp-iota2-lumpy board
> 
> Petr Benes (2):
>   dt-bindings: usb: Add Diodes Incorporated PI5USB30213A Type-C
>     Controller
>   arm64: dts: imx8mp-iota2: Enable the USB Type-C port
> 
>  .../devicetree/bindings/arm/fsl.yaml          |   1 +
>  .../bindings/usb/diodes,pi5usb30213a.yaml     |  95 ++++
>  arch/arm64/boot/dts/freescale/Makefile        |   1 +
>  .../boot/dts/freescale/imx8mp-iota2-lumpy.dts | 521 ++++++++++++++++++
>  4 files changed, 618 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/diodes,pi5usb30213a.yaml
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts
> 
> --
> 2.43.0
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y freescale/imx8mp-iota2-lumpy.dtb' for 20240917151001.1289399-1-michal.vokac@...ft.com:

arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dtb: pwm@...90000: 'pwm-gpios' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/pwm/imx-pwm.yaml#
arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dtb: pcie-ep@...00000: reg: [[864026624, 4194304], [402653184, 134217728]] is too short
	from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie-ep.yaml#
arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dtb: pcie-ep@...00000: reg-names: ['dbi', 'addr_space'] is too short
	from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie-ep.yaml#
arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dtb: usb@...00000: 'pinctrl-0' is a dependency of 'pinctrl-names'
	from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-consumer.yaml#