linux-kernel - Re: [PATCH 3/4] dt-bindings: usb: Add Diodes Incorporated PI5USB30213A Type-C Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70d365f0-a386-408b-8d5f-5524496526a0@ysoft.com>
Date: Thu, 19 Sep 2024 14:49:56 +0200
From: Michal Vokáč <michal.vokac@...ft.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Shawn Guo <shawnguo@...nel.org>, Petr Benes <petr.benes@...ft.com>
Cc: Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 Herburger <gregor.herburger@...tq-group.com>,
 Hiago De Franco <hiago.franco@...adex.com>,
 Hugo Villeneuve <hvilleneuve@...onoff.com>,
 Joao Paulo Goncalves <joao.goncalves@...adex.com>,
 Michael Walle <mwalle@...nel.org>,
 Alexander Stein <alexander.stein@...tq-group.com>,
 Mathieu Othacehe <m.othacehe@...il.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/4] dt-bindings: usb: Add Diodes Incorporated
 PI5USB30213A Type-C Controller

On 18. 09. 24 15:16, Krzysztof Kozlowski wrote:
> On 17/09/2024 17:10, Michal Vokáč wrote:
>> From: Petr Benes <petr.benes@...ft.com>
>>
>> Diodes Incorporated PI5USB30213A Type-C Controller supports host,
>> device, and dual-role mode based on voltage levels detected on CC
>> pin. Supports dual differential channel, 2:1 USB 3.0 Mux/Demux,
>> USB Type-C specification 1.1.
>>
>> Signed-off-by: Petr Benes <petr.benes@...ft.com>
>> Signed-off-by: Michal Vokáč <michal.vokac@...ft.com>
>> ---
>>   .../bindings/usb/diodes,pi5usb30213a.yaml     | 95 +++++++++++++++++++
>>   1 file changed, 95 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/usb/diodes,pi5usb30213a.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/usb/diodes,pi5usb30213a.yaml b/Documentation/devicetree/bindings/usb/diodes,pi5usb30213a.yaml
>> new file mode 100644
>> index 000000000000..1cae10724152
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/diodes,pi5usb30213a.yaml
>> @@ -0,0 +1,95 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Fdiodes%2Cpi5usb30213a.yaml%23&data=05%7C02%7Cmichal.vokac%40ysoft.com%7C925faa72b27547fa80c308dcd7e425f4%7Cb5839965430f4be2b282d7a3149f2b37%7C0%7C0%7C638622622118849100%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=T2NXqovVWUhM4ID1XdytvSaD9yQMKLH9QfQ%2FwFJ9xOs%3D&reserved=0
>> +$schema: https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C02%7Cmichal.vokac%40ysoft.com%7C925faa72b27547fa80c308dcd7e425f4%7Cb5839965430f4be2b282d7a3149f2b37%7C0%7C0%7C638622622118861671%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=tAR73Ny5eXo1GmO4%2BAqiUhpqLdwEgOrfuzwtY4b7K%2Bs%3D&reserved=0
>> +
>> +title: PI5USB30213A Type-C port controller
>> +
>> +description:
>> +  Diodes Incorporated PI5USB30213A Type-C Controller supports host,
>> +  device, and dual-role mode based on voltage levels detected on CC
>> +  pin. Dual differential channel, 2:1 USB 3.0 Mux/Demux, USB Type-C
>> +  specification 1.1 compliant.
>> +
>> +maintainers:
>> +  - Petr Benes <petr.benes@...ft.com>
> 
> Please put maintainers before description: block.

OK

>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - diodes,pi5usb30213a
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  connector:
>> +    type: object
>> +    $ref: ../connector/usb-connector.yaml#
> 
> Full path, so /schemas/connector/usb-....

OK.
  
>> +    unevaluatedProperties: false
>> +    description:
>> +      The managed USB Type-C connector.
> 
> Description should not be needed.

OK, I will remove it.

>> +
>> +    properties:
>> +      compatible:
>> +        const: usb-c-connector
> 
> Drop, not needed.

OK.

>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - connector
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> +    i2c {
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +
>> +      pi5usb30213a: tcpc@d {
> 
> typec@d
> 
> and drop label

OK.
  
>> +        compatible = "diodes,pi5usb30213a";
>> +        reg = <0xd>;
>> +        pinctrl-names = "default";
>> +        pinctrl-0 = <&pinctrl_typec>;
>> +        interrupts-extended = <&gpio1 5 IRQ_TYPE_LEVEL_LOW>;
>> +        status = "okay";
> 
> Drop status

OK.

Thank you for the review,
Michal