[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c4421504-2ccd-4adb-8df6-053c8085080a@ysoft.com>
Date: Thu, 19 Sep 2024 14:52:59 +0200
From: Michal Vokáč <michal.vokac@...ft.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Shawn Guo <shawnguo@...nel.org>, Petr Benes <petr.benes@...ft.com>
Cc: Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Herburger <gregor.herburger@...tq-group.com>,
Hiago De Franco <hiago.franco@...adex.com>,
Hugo Villeneuve <hvilleneuve@...onoff.com>,
Joao Paulo Goncalves <joao.goncalves@...adex.com>,
Michael Walle <mwalle@...nel.org>,
Alexander Stein <alexander.stein@...tq-group.com>,
Mathieu Othacehe <m.othacehe@...il.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 4/4] arm64: dts: imx8mp-iota2: Enable the USB Type-C port
On 18. 09. 24 15:17, Krzysztof Kozlowski wrote:
> On 17/09/2024 17:10, Michal Vokáč wrote:
>> From: Petr Benes <petr.benes@...ft.com>
>>
>> Enable the USB Type-C port with the Diodes PI5USB30213A port controller.
>> The port supports dual role data but can operate only in source power role
>> and PD is not supported.
>>
>> Signed-off-by: Petr Benes <petr.benes@...ft.com>
>> Signed-off-by: Michal Vokáč <michal.vokac@...ft.com>
>> ---
>> .../boot/dts/freescale/imx8mp-iota2-lumpy.dts | 96 +++++++++++++++++++
>> 1 file changed, 96 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts b/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts
>> index 21d0899cabd5..b15d211e8667 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts
>> @@ -38,6 +38,17 @@ memory@...00000 {
>> <0x1 0x00000000 0 0x80000000>;
>> };
>>
>> + reg_typec: regulator-typec {
>> + compatible = "regulator-fixed";
>> + enable-active-high;
>> + gpio = <&gpio1 12 GPIO_ACTIVE_HIGH>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_usbc_vbus>;
>> + regulator-max-microvolt = <5000000>;
>> + regulator-min-microvolt = <5000000>;
>> + regulator-name = "typec";
>> + };
>> +
>> reg_usb_host: regulator-usb-host {
>> compatible = "regulator-fixed";
>> enable-active-high;
>> @@ -218,6 +229,47 @@ &i2c2 {
>> pinctrl-0 = <&pinctrl_i2c2>;
>> status = "okay";
>>
>> + tcpc@d {
>
> typec@d
>
>> + compatible = "diodes,pi5usb30213a";
>> + reg = <0xd>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_typec>;
>> + interrupts-extended = <&gpio1 5 IRQ_TYPE_LEVEL_LOW>;
>> + status = "okay";
>
> Drop
OK. I will address both comments.
Thank you for the review,
Michal
Powered by blists - more mailing lists