linux-kernel - Re: [PATCH] wifi: mwifiex: fix firmware crash for AP DFS mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871q1gdeul.fsf@kernel.org>
Date: Wed, 18 Sep 2024 20:57:38 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Francesco Dolcini <francesco@...cini.it>
Cc: David Lin <yu-hao.lin@....com>,  l.stach@...gutronix.de,
  linux-wireless@...r.kernel.org,  linux-kernel@...r.kernel.org,
  briannorris@...omium.org,  tsung-hsien.hsieh@....com
Subject: Re: [PATCH] wifi: mwifiex: fix firmware crash for AP DFS mode

Francesco Dolcini <francesco@...cini.it> writes:

> +Lucas (in case he missed this patch)
>
> On Fri, Aug 30, 2024 at 04:07:19PM +0800, David Lin wrote:
>> Firmware crashes when AP works on a DFS channel and radar detection occurs.
>> This patch fixes the issue, also add "fake_radar_detect" entry to mimic
>> radar detection for testing purpose.
>
> Do we want such kind of "fake" code in the driver?

BTW in ath11k we have dfs_simulate_radar debugfs file for testing DFS, I
assume this is something similar. So there are benefits from having it.

> I do not agree that we mix an actual bug fix with additional testing code,
> and if I understand correctly the commit message this is what we are doing
> here.

Yeah, we have a rule "one logical change per patch". So the debugfs
addition needs to be in a separate patch.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches