linux-kernel - RE: [EXT] Re: [PATCH] wifi: mwifiex: fix firmware crash for AP DFS mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PA4PR04MB96384683DCF221147DA50E95D1632@PA4PR04MB9638.eurprd04.prod.outlook.com>
Date: Thu, 19 Sep 2024 01:47:07 +0000
From: David Lin <yu-hao.lin@....com>
To: Kalle Valo <kvalo@...nel.org>, Francesco Dolcini <francesco@...cini.it>
CC: "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"briannorris@...omium.org" <briannorris@...omium.org>, Pete Hsieh
	<tsung-hsien.hsieh@....com>
Subject: RE: [EXT] Re: [PATCH] wifi: mwifiex: fix firmware crash for AP DFS
 mode

> From: Kalle Valo <kvalo@...nel.org>
> Sent: Thursday, September 19, 2024 1:58 AM
> To: Francesco Dolcini <francesco@...cini.it>
> Cc: David Lin <yu-hao.lin@....com>; l.stach@...gutronix.de;
> linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org;
> briannorris@...omium.org; Pete Hsieh <tsung-hsien.hsieh@....com>
> Subject: [EXT] Re: [PATCH] wifi: mwifiex: fix firmware crash for AP DFS mode
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> Francesco Dolcini <francesco@...cini.it> writes:
> 
> > +Lucas (in case he missed this patch)
> >
> > On Fri, Aug 30, 2024 at 04:07:19PM +0800, David Lin wrote:
> >> Firmware crashes when AP works on a DFS channel and radar detection
> occurs.
> >> This patch fixes the issue, also add "fake_radar_detect" entry to
> >> mimic radar detection for testing purpose.
> >
> > Do we want such kind of "fake" code in the driver?
> 
> BTW in ath11k we have dfs_simulate_radar debugfs file for testing DFS, I
> assume this is something similar. So there are benefits from having it.
> 

Nice to know it.

> > I do not agree that we mix an actual bug fix with additional testing
> > code, and if I understand correctly the commit message this is what we
> > are doing here.
> 
> Yeah, we have a rule "one logical change per patch". So the debugfs addition
> needs to be in a separate patch.
> 

O.K. I will create another patch to add this debugfs file for radar detection test.

David