linux-kernel - Re: [GIT PULL] Performance events changes for v6.12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZuvkDlws6xvijIuc@gmail.com>
Date: Thu, 19 Sep 2024 10:42:54 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jiri Olsa <jolsa@...hat.com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Mark Rutland <mark.rutland@....com>,
	Namhyung Kim <namhyung@...nel.org>,
	linux-perf-users@...r.kernel.org
Subject: Re: [GIT PULL] Performance events changes for v6.12


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Wed, Sep 18, 2024 at 2:45 PM Ingo Molnar <mingo@...nel.org> wrote:
> >
> >  arch/x86/events/core.c                                |  63 +++++++++++++++++++
> >  arch/x86/events/intel/bts.c                           |   3 -
> [...]
> >  kernel/events/core.c                                  | 586 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------
> >  kernel/events/uprobes.c                               | 505 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------------
> 
> You seem to be cutting-and-pasting your diffstats from a *very* wide
> terminal window, resulting in a very messy diffstat result.

Yeah, sorry about that - it was a one-off manual diffstat due to the merge 
order between perf/urgent and perf/core, and indeed my terminal is ~240 
characters wide and I didn't notice the diffstat width-scaling weirdness.

> Please either pipe the git request-pull output to some tool (I suggest 
> just piping to 'xsel' or similar that does the 'cut' part for you, but 
> anything works - you can just do "| cat" to make the stdout not be the 
> terminal).
> 
> Or just use "--stat=80" to set the output width to a fixed sane thing, 
> instead of that insane 250+ character window width that it seems you are 
> using and that causes those overlong diffstat lines and makes it all hard 
> to read.

Will do next time it happens. Below is a belated diffstat with the correct 
width.

Thanks,

	Ingo

 arch/x86/events/core.c                             |  63 +++
 arch/x86/events/intel/bts.c                        |   3 -
 arch/x86/events/intel/cstate.c                     | 142 +----
 arch/x86/events/intel/pt.c                         |  29 +-
 arch/x86/events/intel/uncore.c                     |   9 +
 arch/x86/events/intel/uncore.h                     |   2 +
 arch/x86/events/intel/uncore_snb.c                 | 185 ++++++-
 drivers/dma/idxd/idxd.h                            |   7 -
 drivers/dma/idxd/init.c                            |   3 -
 drivers/dma/idxd/perfmon.c                         |  98 +---
 drivers/iommu/intel/iommu.h                        |   2 -
 drivers/iommu/intel/perfmon.c                      | 111 +---
 include/linux/cpuhotplug.h                         |   2 -
 include/linux/perf_event.h                         |  32 +-
 include/linux/rbtree.h                             |  67 +++
 include/linux/uprobes.h                            |  48 +-
 kernel/events/core.c                               | 586 +++++++++++++++------
 kernel/events/uprobes.c                            | 505 ++++++++++--------
 kernel/trace/bpf_trace.c                           |  38 +-
 kernel/trace/trace_uprobe.c                        |  44 +-
 .../selftests/bpf/bpf_testmod/bpf_testmod.c        |  27 +-
 21 files changed, 1146 insertions(+), 857 deletions(-)