linux-kernel - Re: [PATCH 2/9] spi: spi_amd: Enable dual and quad I/O modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZuvkOohXSzLZZAw7@finisterre.sirena.org.uk>
Date: Thu, 19 Sep 2024 10:43:38 +0200
From: Mark Brown <broonie@...nel.org>
To: Raju Rangoju <Raju.Rangoju@....com>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	sanju.mehta@....com, krishnamoorthi.m@....com,
	akshata.mukundshetty@....com
Subject: Re: [PATCH 2/9] spi: spi_amd: Enable dual and quad I/O modes

On Wed, Sep 18, 2024 at 04:20:30PM +0530, Raju Rangoju wrote:

>  {
>  	/* bus width is number of IO lines used to transmit */
> -	if (op->cmd.buswidth > 1 || op->addr.buswidth > 1 ||
> -	    op->data.buswidth > 1 || op->data.nbytes > AMD_SPI_MAX_DATA)
> +	if (op->cmd.buswidth > 1 || op->addr.buswidth > 4 ||
> +	    op->data.buswidth > 4 || op->data.nbytes > AMD_SPI_MAX_DATA)
>  		return false;

I'm not seeing anything where we tell the hardware about the width?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)