linux-kernel - Re: [PATCH -next] RDMA/bnxt_re: Remove the unused variable en

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+sbYW0zy=kD1JyYbG--keYAv146+SXvuxdQh6dHnvbVCHd9kw@mail.gmail.com>
Date: Thu, 19 Sep 2024 14:16:11 +0530
From: Selvin Xavier <selvin.xavier@...adcom.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: jgg@...pe.ca, leon@...nel.org, linux-rdma@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] RDMA/bnxt_re: Remove the unused variable en_dev

On Wed, Sep 18, 2024 at 7:46 AM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> Variable en_dev is not effectively used, so delete it.
>
> drivers/infiniband/hw/bnxt_re/main.c:1980:22: warning: variable ‘en_dev’ set but not used.

Not sure if you are applying v1 of a previous patch series. A similar
issue was reported by kernel test robot and i fixed in v2. I dont see
this code in the latest driver code.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10867
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/infiniband/hw/bnxt_re/main.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
> index adff9e494c9d..777068de4bbc 100644
> --- a/drivers/infiniband/hw/bnxt_re/main.c
> +++ b/drivers/infiniband/hw/bnxt_re/main.c
> @@ -1977,7 +1977,6 @@ static void bnxt_re_remove_device(struct bnxt_re_dev *rdev, u8 op_type,
>  static void bnxt_re_remove(struct auxiliary_device *adev)
>  {
>         struct bnxt_re_en_dev_info *en_info = auxiliary_get_drvdata(adev);
> -       struct bnxt_en_dev *en_dev;
>         struct bnxt_re_dev *rdev;
>
>         mutex_lock(&bnxt_re_mutex);
> @@ -1985,7 +1984,6 @@ static void bnxt_re_remove(struct auxiliary_device *adev)
>                 mutex_unlock(&bnxt_re_mutex);
>                 return;
>         }
> -       en_dev = en_info->en_dev;
>         rdev = en_info->rdev;
>
>         if (rdev)
> --
> 2.32.0.3.g01195cf9f
>
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4224 bytes)