linux-kernel - Re: [PATCH -next] RDMA/bnxt_re: Remove the unused variable en

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240922135243.GB11337@unreal>
Date: Sun, 22 Sep 2024 16:52:43 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Selvin Xavier <selvin.xavier@...adcom.com>
Cc: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, jgg@...pe.ca,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] RDMA/bnxt_re: Remove the unused variable en_dev

On Thu, Sep 19, 2024 at 02:16:11PM +0530, Selvin Xavier wrote:
> On Wed, Sep 18, 2024 at 7:46 AM Jiapeng Chong
> <jiapeng.chong@...ux.alibaba.com> wrote:
> >
> > Variable en_dev is not effectively used, so delete it.
> >
> > drivers/infiniband/hw/bnxt_re/main.c:1980:22: warning: variable ‘en_dev’ set but not used.
> 
> Not sure if you are applying v1 of a previous patch series. A similar
> issue was reported by kernel test robot and i fixed in v2. I dont see
> this code in the latest driver code.

Similar but not the same, I applied your v2 series, but Jiapeng's patch
is valid:

  1977 static void bnxt_re_remove(struct auxiliary_device *adev)
  1978 {
  1979         struct bnxt_re_en_dev_info *en_info = auxiliary_get_drvdata(adev);
  1980         struct bnxt_en_dev *en_dev;
  1981         struct bnxt_re_dev *rdev;
  1982
  1983         mutex_lock(&bnxt_re_mutex);
  1984         if (!en_info) {
  1985                 mutex_unlock(&bnxt_re_mutex);
  1986                 return;
  1987         }
  1988         en_dev = en_info->en_dev;
  1989         rdev = en_info->rdev;
  1990
  1991         if (rdev)
  1992                 bnxt_re_remove_device(rdev, BNXT_RE_COMPLETE_REMOVE, adev);
  1993         kfree(en_info);
  1994         mutex_unlock(&bnxt_re_mutex);
  1995 }


Thanks