linux-kernel - Re: [PATCH] dt-bindings: hwmon: Add adt7462

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2229b659-c753-4f56-a1ab-7e8984f9147f@kernel.org>
Date: Thu, 19 Sep 2024 12:39:03 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Chanh Nguyen <chanh@...eremail.onmicrosoft.com>,
 Rob Herring <robh@...nel.org>, Chanh Nguyen <chanh@...amperecomputing.com>
Cc: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
 Open Source Submission <patches@...erecomputing.com>,
 Phong Vo <phong@...amperecomputing.com>,
 Thang Nguyen <thang@...amperecomputing.com>,
 Quan Nguyen <quan@...amperecomputing.com>,
 Khanh Pham <khpham@...erecomputing.com>
Subject: Re: [PATCH] dt-bindings: hwmon: Add adt7462

On 19/09/2024 11:43, Chanh Nguyen wrote:
>>> +properties:
>>> +  compatible:
>>> +    const: onnn,adt7462
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  resets:
>>> +    maxItems: 1
>>
>> How would this work? 'resets' generally is used for on-chip devices and
>> a reset controller. That doesn't exist at the board level. A standalone
>> device typically uses a GPIO lines if there's a s/w controlled reset.
>> That would be the 'reset-gpios' property.
>>
> 
> Thank Rob for your comments! The ADT7462 includes an active low reset 
> pin (Pin #14).
> 
> I'll change 'resets' into the 'reset-gpios' property.
> 
> The example in the binding will be

The question how did it work in the first place is still valid... I
think we might benefit from asking people to post their upstreamed DTS.
Otherwise we will take broken or half-baked bindings, because we never
saw the bigger picture. :(

Best regards,
Krzysztof