| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZuxTjy7I-pZBcXa0@rhfedora> Date: Thu, 19 Sep 2024 12:38:39 -0400 From: "John B. Wyatt IV" <jwyatt@...hat.com> To: "Peng Fan (OSS)" <peng.fan@....nxp.com> Cc: Thomas Renninger <trenn@...e.com>, Shuah Khan <shuah@...nel.org>, John Kacur <jkacur@...hat.com>, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, Peng Fan <peng.fan@....com> Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow overriding cross-compiling envs Hi Peng, A few comments: > V2: > subject update, commit log update in patch 1, 2 > Use strerror in patch 1 > without patch 2, need update Makefile with 'CROSS = > [cross toolchain path]/aarch64-poky-linux-' Version information is applied per commit patch. Not in the cover letter. Example: https://lore.kernel.org/linux-pm/20240905021916.15938-2-jwyatt@redhat.com/ Reference: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format You will need to submit a V3 version of this. > without patch 2, need update Makefile with 'CROSS = > [cross toolchain path]/aarch64-poky-linux-' I am not sure what this is saying exactly. Please clarify. > Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow overriding Not sure you need 'tools: power: cpupower:' in the cover letter. > pm: cpupower: bench: print config file path when open cpufreq-bench.conf fails I do not think you need bench either. -- Sincerely, John Wyatt Software Engineer, Core Kernel Red Hat
Powered by blists - more mailing lists