linux-kernel - Re: [PATCH V4 5/6] arm64: dts: ti: k3-am62: use opp_efuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a54f481-efaa-4719-ac38-b328a6c67762@ti.com>
Date: Thu, 19 Sep 2024 11:40:31 -0500
From: Andrew Davis <afd@...com>
To: Dhruva Gole <d-gole@...com>, Nishanth Menon <nm@...com>,
        Vignesh
 Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>,
        Viresh Kumar
	<viresh.kumar@...aro.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>
CC: <linux-pm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        Rob
 Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH V4 5/6] arm64: dts: ti: k3-am62: use opp_efuse_table for
 opp-table syscon

On 9/19/24 3:28 AM, Dhruva Gole wrote:
> Add another entry in the wkup_conf for the syscon node, and then use
> that for the syscon in opp-table.
> 
> Marking entire wkup_conf as "syscon", "simple-mfd" is wrong and needs to
> be addressed similar to how other child-nodes in wkup_conf are implemented
> in the same file.
> 
> Signed-off-by: Dhruva Gole <d-gole@...com>
> ---
> 
> **DEPENDS ON:** PATCH 6/6: cpufreq: ti-cpufreq: Update the efuse/rev offsets
> 
> Link to v1: https://lore.kernel.org/all/20240902093222.2828345-2-d-gole@ti.com/
> No changes, just combined it as part of Bryan's AM62A and AM62P series
> and sending it all together.
> 
> ---
>   arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 7 ++++++-
>   arch/arm64/boot/dts/ti/k3-am625.dtsi       | 2 +-
>   2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> index e0afafd532a5..b2b65e31c7cf 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> @@ -10,7 +10,7 @@
>   &cbass_wakeup {
>   	wkup_conf: syscon@...00000 {
>   		bootph-all;
> -		compatible = "syscon", "simple-mfd";
> +		compatible = "simple-bus";

This can be done in a separate patch after this one. You'll also
want to change the syscon@...00000 to bus@...00000, and drop the
"reg = <>;" line at the same time.

Andrew

>   		reg = <0x00 0x43000000 0x00 0x20000>;
>   		#address-cells = <1>;
>   		#size-cells = <1>;
> @@ -22,6 +22,11 @@ chipid: chipid@14 {
>   			reg = <0x14 0x4>;
>   		};
>   
> +		opp_efuse_table: syscon@18 {
> +			compatible = "ti,am62-opp-efuse-table", "syscon";
> +			reg = <0x18 0x4>;
> +		};
> +
>   		cpsw_mac_syscon: ethernet-mac-syscon@200 {
>   			compatible = "ti,am62p-cpsw-mac-efuse", "syscon";
>   			reg = <0x200 0x8>;
> diff --git a/arch/arm64/boot/dts/ti/k3-am625.dtsi b/arch/arm64/boot/dts/ti/k3-am625.dtsi
> index c3d1db47dc9f..c249883a8a8d 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am625.dtsi
> @@ -108,7 +108,7 @@ cpu3: cpu@3 {
>   	a53_opp_table: opp-table {
>   		compatible = "operating-points-v2-ti-cpu";
>   		opp-shared;
> -		syscon = <&wkup_conf>;
> +		syscon = <&opp_efuse_table>;
>   
>   		opp-200000000 {
>   			opp-hz = /bits/ 64 <200000000>;