linux-kernel - Re: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zu4Ng6DAYcQHCqPJ@pengfei-OptiPlex-Tower-Plus-7010>
Date: Fri, 20 Sep 2024 17:04:19 -0700
From: Pengfei Li <pengfei.li_1@....com>
To: Abel Vesa <abel.vesa@...aro.org>
Cc: krzk+dt@...nel.org, robh@...nel.org, abelvesa@...nel.org,
	mturquette@...libre.com, sboyd@...nel.org, conor+dt@...nel.org,
	shawnguo@...nel.org, s.hauer@...gutronix.de, ping.bai@....com,
	ye.li@....com, peng.fan@....com, aisheng.dong@....com,
	frank.li@....com, kernel@...gutronix.de, festevam@...il.com,
	linux-clk@...r.kernel.org, imx@...ts.linux.dev,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

On Thu, Aug 29, 2024 at 10:07:05AM +0300, Abel Vesa wrote:
> On 24-06-27 16:24:24, Pengfei Li wrote:
> > 'IMX93_CLK_END' macro was previously defined in imx93-clock.h to
> > indicate the number of clocks, but it is not part of the ABI, so
> > it should be moved to clk driver.
> > 
> 
> Right, why?
> 
> All other providers have been using the _CLK_END from the bindings
> header. What is so special about this ? AFAICT, nothing.
> 
> > ---
> > Change for v2:
> > - Use pre-processor define to simplify code.
> > - link to v1: https://lore.kernel.org/all/20240625175147.94985-1-pengfei.li_1@nxp.com/
> > 
> > Pengfei Li (2):
> >   clk: imx93: Move IMX93_CLK_END macro to clk driver
> >   dt-bindings: clock: imx93: Drop IMX93_CLK_END macro definition
> > 
> >  drivers/clk/imx/clk-imx93.c             | 2 ++
> >  include/dt-bindings/clock/imx93-clock.h | 1 -
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> > 
> > -- 
> > 2.34.1
> > 
> 

Hi Abel,

This is a modification based on previous comments: https://lore.kernel.org/all/20240604150447.GA604729-robh@kernel.org/
Actually, whether this _CLK_END macro change is added or not, both is ok for me.
I just want to add some new clocks to bindings header.

BR,
Pengfei Li