linux-kernel - Re: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a07828a4-8040-42cb-8c62-8939cac4d9de@kernel.org>
Date: Fri, 20 Sep 2024 15:27:26 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Abel Vesa <abel.vesa@...aro.org>, Pengfei Li <pengfei.li_1@....com>
Cc: krzk+dt@...nel.org, robh@...nel.org, abelvesa@...nel.org,
 mturquette@...libre.com, sboyd@...nel.org, conor+dt@...nel.org,
 shawnguo@...nel.org, s.hauer@...gutronix.de, ping.bai@....com,
 ye.li@....com, peng.fan@....com, aisheng.dong@....com, frank.li@....com,
 kernel@...gutronix.de, festevam@...il.com, linux-clk@...r.kernel.org,
 imx@...ts.linux.dev, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

On 29/08/2024 09:07, Abel Vesa wrote:
> On 24-06-27 16:24:24, Pengfei Li wrote:
>> 'IMX93_CLK_END' macro was previously defined in imx93-clock.h to
>> indicate the number of clocks, but it is not part of the ABI, so
>> it should be moved to clk driver.
>>
> 
> Right, why?
> 
> All other providers have been using the _CLK_END from the bindings
> header. What is so special about this ? AFAICT, nothing.

Because usually we do no consider number of clocks as an ABI. For
starters it does no really appear in DTS. But what's more important -
new clocks are described later, which contradicts this define. So either
this is an ABI or it is not. If it is, you are not allowed to add any
new clock. If it is not, then this should have never been part of bindings.

We did the same (removal of END/NUM macros) for several other platforms
already.

Best regards,
Krzysztof