linux-kernel - Re: [PATCH v3] crypto: Removing CRYPTO_AES_GCM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ldzmll80.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me>
Date: Fri, 20 Sep 2024 15:07:19 +0530
From: Kamlesh Gurudasani <kamlesh@...com>
To: Danny Tsen <dtsen@...ux.ibm.com>, <linux-crypto@...r.kernel.org>
CC: <stable@...r.kernel.org>, <herbert@...dor.apana.org.au>,
        <leitao@...ian.org>, <nayna@...ux.ibm.com>, <appro@...ptogams.org>,
        <linux-kernel@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
        <mpe@...erman.id.au>, <ltcgcw@...ux.vnet.ibm.com>, <dtsen@...ibm.com>,
        Danny
 Tsen <dtsen@...ux.ibm.com>
Subject: Re: [PATCH v3] crypto: Removing CRYPTO_AES_GCM_P10.

Danny Tsen <dtsen@...ux.ibm.com> writes:

> Data mismatch found when testing ipsec tunnel with AES/GCM crypto.
> Disabling CRYPTO_AES_GCM_P10 in Kconfig for this feature.
>
> Fixes: fd0e9b3e2ee6 ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")
> Fixes: cdcecfd9991f ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
> Fixes: 45a4672b9a6e2 ("crypto: p10-aes-gcm - Update Kconfig and Makefile")
>
> Signed-off-by: Danny Tsen <dtsen@...ux.ibm.com>
nitpick
checkpatch complains
Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' -
ie: 'Fixes: 45a4672b9a6e ("crypto: p10-aes-gcm - Update Kconfig and
Makefile")'

There is no rule for 12 characters, but it is generally preferred.
I guess it is just a typo for you as you have correctly added other
Fixes tag.

If you end up re-spinning, please correct this

Also, just to understand,

"A Fixes: tag indicates that the patch fixes an issue in a previous
 commit. It is used to make it easy to determine where a bug originated,
 which can help review a bug fix"

from 
https://docs.kernel.org/process/submitting-patches.html

should there not be just single Fixes tag? as bug originated from one
commit, may be the commit that actually broke the functionality.

P.S.
Not expert on this, just trying to learn.

Kamlesh