linux-kernel - Re: [PATCH v3] crypto: Removing CRYPTO_AES_GCM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240921151642.60b89e86@canb.auug.org.au>
Date: Sat, 21 Sep 2024 15:16:42 +1000
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Kamlesh Gurudasani <kamlesh@...com>
Cc: Danny Tsen <dtsen@...ux.ibm.com>, <linux-crypto@...r.kernel.org>,
 <stable@...r.kernel.org>, <herbert@...dor.apana.org.au>,
 <leitao@...ian.org>, <nayna@...ux.ibm.com>, <appro@...ptogams.org>,
 <linux-kernel@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
 <mpe@...erman.id.au>, <ltcgcw@...ux.vnet.ibm.com>, <dtsen@...ibm.com>
Subject: Re: [PATCH v3] crypto: Removing CRYPTO_AES_GCM_P10.

Hi Kamlesh,

On Fri, 20 Sep 2024 15:07:19 +0530 Kamlesh Gurudasani <kamlesh@...com> wrote:
>
> Danny Tsen <dtsen@...ux.ibm.com> writes:
> 
> > Data mismatch found when testing ipsec tunnel with AES/GCM crypto.
> > Disabling CRYPTO_AES_GCM_P10 in Kconfig for this feature.
> >
> > Fixes: fd0e9b3e2ee6 ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")
> > Fixes: cdcecfd9991f ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
> > Fixes: 45a4672b9a6e2 ("crypto: p10-aes-gcm - Update Kconfig and Makefile")
> >
> > Signed-off-by: Danny Tsen <dtsen@...ux.ibm.com>  
> nitpick
> checkpatch complains
> Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' -
> ie: 'Fixes: 45a4672b9a6e ("crypto: p10-aes-gcm - Update Kconfig and
> Makefile")'
> 
> There is no rule for 12 characters, but it is generally preferred.
> I guess it is just a typo for you as you have correctly added other
> Fixes tag.

It should be at least 12 hex digits i.e. more is fine.  It is possible
that some commits need more than 12 hex digits of the SHA1 to be
uniquely identified in some git repositories already.  I guess
checkpatch needs a patch.

> Also, just to understand,
> 
> "A Fixes: tag indicates that the patch fixes an issue in a previous
>  commit. It is used to make it easy to determine where a bug originated,
>  which can help review a bug fix"
> 
> from 
> https://docs.kernel.org/process/submitting-patches.html
> 
> should there not be just single Fixes tag? as bug originated from one
> commit, may be the commit that actually broke the functionality.

While we generally prefer that a patch only fix one bug, it is very
possible that the bug may have been introduced in more than one commit
e.g. in different files.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped