linux-kernel - Re: [PATCH v2] mac802154: Fix potential RCU dereference issue in mac802154_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240920132131.466e5636@xps-13>
Date: Fri, 20 Sep 2024 13:21:31 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Jiawei Ye <jiawei.ye@...mail.com>
Cc: przemyslaw.kitszel@...el.com, alex.aring@...il.com,
 stefan@...enfreihafen.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, david.girault@...vo.com,
 linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mac802154: Fix potential RCU dereference issue in
 mac802154_scan_worker

Hi Jiawei,

jiawei.ye@...mail.com wrote on Fri, 20 Sep 2024 04:03:32 +0000:

> In the `mac802154_scan_worker` function, the `scan_req->type` field was
> accessed after the RCU read-side critical section was unlocked. According
> to RCU usage rules, this is illegal and can lead to unpredictable
> behavior, such as accessing memory that has been updated or causing
> use-after-free issues.
> 
> This possible bug was identified using a static analysis tool developed
> by myself, specifically designed to detect RCU-related issues.
> 
> To address this, the `scan_req->type` value is now stored in a local
> variable `scan_req_type` while still within the RCU read-side critical
> section. The `scan_req_type` is then used after the RCU lock is released,
> ensuring that the type value is safely accessed without violating RCU
> rules.
> 
> Fixes: e2c3e6f53a7a ("mac802154: Handle active scanning")
> Signed-off-by: Jiawei Ye <jiawei.ye@...mail.com>

I think net maintainers now expect the Cc: stable tag to be put here
when there is a reason to backport, which I believe is the case here.
So please add this line here.

> 

Please delete this blank line as well.

And with that you can add my:

Acked-by: Miquel Raynal <miquel.raynal@...tlin.com>

> ---

Thanks,
Miquèl