linux-kernel - Re: [PATCH v2 3/4] serial: 8250_exar: Replace custom EEPROM read with eeprom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240920110913.66f768d0@SWDEV2.connecttech.local>
Date: Fri, 20 Sep 2024 11:09:13 -0400
From: Parker Newman <parker@...est.io>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby
 <jirislaby@...nel.org>, Arnd Bergmann <arnd@...db.de>,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, Parker Newman
 <pnewman@...necttech.com>
Subject: Re: [PATCH v2 3/4] serial: 8250_exar: Replace custom EEPROM read
 with eeprom_93cx6

On Fri, 20 Sep 2024 17:55:33 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Fri, Sep 20, 2024 at 10:03:23AM -0400, Parker Newman wrote:
> > From: Parker Newman <pnewman@...necttech.com>
> >
> > Replace the custom 93cx6 EEPROM read functions with the eeprom_93cx6
> > driver. This removes duplicate code and improves code readability.
> >
> > exar_ee_read() calls are replaced with eeprom_93cx6_read() or
> > eeprom_93cx6_multiread().
> >
> > Add "select EEPROM_93CX6" to config SERIAL_8250_EXAR to ensure
> > eeprom_93cx6 driver is also compiled when 8250_exar driver is selected.
> >
> > Note: Old exar_ee_read() and associated functions are removed in next
> > patch in this series.
>
> Looks perfect!
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
> Let's wait for others and CIs to test all this and then after v6.12-rc1
> is out (presumably within ~ten days) rebase your series (as I suggested
> in another reply) and send a v3.
>

Sounds good, I will wait for v6.12-rc1, rebase and send v3 with the
changes you (or others) suggested. I promise I won't forget the Reviewed-by
tags this time :).

> Good work!
>

Thanks and thanks for the help!
-Parker