linux-kernel - Re: [PATCH v2 3/4] serial: 8250_exar: Replace custom EEPROM read with eeprom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240920114221.57da8890@SWDEV2.connecttech.local>
Date: Fri, 20 Sep 2024 11:42:21 -0400
From: Parker Newman <parker@...est.io>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby
 <jirislaby@...nel.org>, Arnd Bergmann <arnd@...db.de>,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, Parker Newman
 <pnewman@...necttech.com>
Subject: Re: [PATCH v2 3/4] serial: 8250_exar: Replace custom EEPROM read
 with eeprom_93cx6

On Fri, 20 Sep 2024 18:26:08 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Fri, Sep 20, 2024 at 10:03:23AM -0400, Parker Newman wrote:
> > From: Parker Newman <pnewman@...necttech.com>
>
> ...
>
> > +	osc_freq = le16_to_cpu(ee_words[0]) | (le16_to_cpu(ee_words[1]) << 16);
> > +	if (osc_freq == GENMASK(31, 0))
> >  		return -EIO;
>
> Just noticed that you have
> #define CTI_EE_MASK_OSC_FREQ_LOWER      GENMASK(15, 0)
> #define CTI_EE_MASK_OSC_FREQ_UPPER      GENMASK(31, 16)
>
> So, please modify them and the above check using these.
> Something like
>

Good catch, I debated using them again with FIELD_PREP() like the
old code but it looked pretty ugly. I guess I missed removing them.

I will fix in v3. In this case should I drop your Reviewed-by tag?
Or is this change small enough to keep it?

> #define CTI_EE_MASK_OSC_FREQ		GENMASK(31, 0)
>
> 	osc_freq = le16_to_cpu(ee_words[0]) | (le16_to_cpu(ee_words[1]) << 16);
> 	if (osc_freq == CTI_EE_MASK_OSC_FREQ)
> 		return -EIO;
>
> P.S> If I am not mistaken the definitions were only used in this function.
>