linux-kernel - Re: [PATCH 5/6] ASoC: dt-bindings: Add bindings for NeoFidelity NTP8835

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240920174233.hisfcfb6pgtqzyfp@pc>
Date: Fri, 20 Sep 2024 20:42:33 +0300
From: Igor Prusov <ivprusov@...utedevices.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, "Rob
 Herring" <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, "Conor
 Dooley" <conor+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
	<tiwai@...e.com>, Philipp Zabel <p.zabel@...gutronix.de>,
	<prusovigor@...il.com>, <kernel@...utedevices.com>,
	<linux-sound@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/6] ASoC: dt-bindings: Add bindings for NeoFidelity
 NTP8835

On Wed, Jul 10, 2024 at 12:24:33PM +0200, Krzysztof Kozlowski wrote:
> On 09/07/2024 19:28, Igor Prusov wrote:
> > Add dt-bindings for NeoFidelity NTP8835C/NTP8835C Amplifiers
> > 
> > Signed-off-by: Igor Prusov <ivprusov@...utedevices.com>
> > ---
> >  .../bindings/sound/neofidelity,ntp8835.yaml   | 65 +++++++++++++++++++
> 
> No need for new schema. Just put it - after testing - into previous
> bindings file.

I am going to add some clocks in next version and there are some
differences between amplifiers. 8835 uses separate master clock, 8918 is
clocked by BCLK. Is it still better to use same schema with anyOf, or
keep them in different files?

> 
> Best regards,
> Krzysztof
> 

-- 
Best Regards,
Igor Prusov