| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202409212211.Lopmt0MK-lkp@intel.com>
Date: Sat, 21 Sep 2024 22:42:15 +0800
From: kernel test robot <lkp@...el.com>
To: Steven Davis <goldside000@...look.com>, akpm@...ux-foundation.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Steven Davis <goldside000@...look.com>
Subject: Re: [PATCH] irq_work: Improve CPU Responsiveness in irq_work_sync
with cond_resched()
Hi Steven,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.11 next-20240920]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Steven-Davis/irq_work-Improve-CPU-Responsiveness-in-irq_work_sync-with-cond_resched/20240918-232606
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/SJ2P223MB10263844181902531B671FB6F7622%40SJ2P223MB1026.NAMP223.PROD.OUTLOOK.COM
patch subject: [PATCH] irq_work: Improve CPU Responsiveness in irq_work_sync with cond_resched()
config: parisc-allnoconfig (https://download.01.org/0day-ci/archive/20240921/202409212211.Lopmt0MK-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240921/202409212211.Lopmt0MK-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409212211.Lopmt0MK-lkp@intel.com/
All errors (new ones prefixed by >>):
kernel/irq_work.c: In function 'irq_work_sync':
>> kernel/irq_work.c:311:13: error: invalid storage class for function 'run_irq_workd'
311 | static void run_irq_workd(unsigned int cpu)
| ^~~~~~~~~~~~~
>> kernel/irq_work.c:316:13: error: invalid storage class for function 'irq_workd_setup'
316 | static void irq_workd_setup(unsigned int cpu)
| ^~~~~~~~~~~~~~~
>> kernel/irq_work.c:323:35: error: initializer element is not constant
323 | .setup = irq_workd_setup,
| ^~~~~~~~~~~~~~~
kernel/irq_work.c:323:35: note: (near initialization for 'irqwork_threads.setup')
kernel/irq_work.c:325:35: error: initializer element is not constant
325 | .thread_fn = run_irq_workd,
| ^~~~~~~~~~~~~
kernel/irq_work.c:325:35: note: (near initialization for 'irqwork_threads.thread_fn')
>> kernel/irq_work.c:329:19: error: invalid storage class for function 'irq_work_init_threads'
329 | static __init int irq_work_init_threads(void)
| ^~~~~~~~~~~~~~~~~~~~~
In file included from arch/parisc/include/asm/alternative.h:18,
from arch/parisc/include/asm/barrier.h:5,
from include/asm-generic/bitops/generic-non-atomic.h:7,
from include/linux/bitops.h:29,
from include/linux/kernel.h:23,
from arch/parisc/include/asm/bug.h:5,
from include/linux/bug.h:5,
from kernel/irq_work.c:9:
kernel/irq_work.c:335:16: error: initializer element is not constant
335 | early_initcall(irq_work_init_threads);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/init.h:270:55: note: in definition of macro '____define_initcall'
270 | __attribute__((__section__(__sec))) = fn;
| ^~
include/linux/init.h:280:9: note: in expansion of macro '__unique_initcall'
280 | __unique_initcall(fn, id, __sec, __initcall_id(fn))
| ^~~~~~~~~~~~~~~~~
include/linux/init.h:282:35: note: in expansion of macro '___define_initcall'
282 | #define __define_initcall(fn, id) ___define_initcall(fn, id, .initcall##id)
| ^~~~~~~~~~~~~~~~~~
include/linux/init.h:289:41: note: in expansion of macro '__define_initcall'
289 | #define early_initcall(fn) __define_initcall(fn, early)
| ^~~~~~~~~~~~~~~~~
kernel/irq_work.c:335:1: note: in expansion of macro 'early_initcall'
335 | early_initcall(irq_work_init_threads);
| ^~~~~~~~~~~~~~
>> kernel/irq_work.c:335:1: error: expected declaration or statement at end of input
vim +/run_irq_workd +311 kernel/irq_work.c
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 310
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 @311 static void run_irq_workd(unsigned int cpu)
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 312 {
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 313 irq_work_run_list(this_cpu_ptr(&lazy_list));
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 314 }
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 315
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 @316 static void irq_workd_setup(unsigned int cpu)
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 317 {
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 318 sched_set_fifo_low(current);
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 319 }
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 320
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 321 static struct smp_hotplug_thread irqwork_threads = {
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 322 .store = &irq_workd,
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 @323 .setup = irq_workd_setup,
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 324 .thread_should_run = irq_workd_should_run,
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 325 .thread_fn = run_irq_workd,
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 326 .thread_comm = "irq_work/%u",
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 327 };
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 328
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 @329 static __init int irq_work_init_threads(void)
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 330 {
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 331 if (IS_ENABLED(CONFIG_PREEMPT_RT))
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 332 BUG_ON(smpboot_register_percpu_thread(&irqwork_threads));
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 333 return 0;
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 334 }
b4c6f86ec2f648 Sebastian Andrzej Siewior 2021-10-07 @335 early_initcall(irq_work_init_threads);
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists