linux-kernel - Re: [GIT PULL] MM updates for 6.12-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjUiO3qUVR6ydhGjby3yf_KQO5+m7Hfb4H09kXXPogZ7g@mail.gmail.com>
Date: Sun, 22 Sep 2024 09:34:42 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org, 
	mm-commits@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Huang Ying <ying.huang@...el.com>, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [GIT PULL] MM updates for 6.12-rc1

On Sun, 22 Sept 2024 at 02:32, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
>     kernel/resource.c: In function ‘gfr_start’:
>     ./include/linux/minmax.h:93:30: error: conversion from ‘long long
> unsigned int’ to ‘resource_size_t’ {aka ‘unsigned int’} changes value
> from ‘18446744073709551615’ to ‘4294967295’ [-Werror=overflow]
>
> Due to
>
>     #define PHYSMEM_END  (-1ULL)
>
> not being correct on 32-bit without LPAE.

Hmm. Can you check if making it be

      #define PHYSMEM_END  ((phys_addr_t)-1)

fixes things for you?

That said, it would probably be even better if we got rid of these
games entirely, and m68k just defined MAX_PHYSMEM_BITS instead. Maybe
as a config option, since I assume it's going to be either 24 or 32
depending on CPU (or are there other choices? I used to know the old
m68k, but...)

                Linus