linux-kernel - Re: [PATCH v2 5/6] KVM: SVM: Inject MCEs when restricted injection is active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJhGHyDB6A1NNNW84jxwL=LToPXqLDb1kZ_kd9N-M+aWCV-kkQ@mail.gmail.com>
Date: Mon, 23 Sep 2024 06:01:46 +0800
From: Lai Jiangshan <jiangshanlai@...il.com>
To: Melody Wang <huibo.wang@....com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org, 
	Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini <pbonzini@...hat.com>, 
	Tom Lendacky <thomas.lendacky@....com>, Ashish Kalra <ashish.kalra@....com>, 
	Michael Roth <michael.roth@....com>
Subject: Re: [PATCH v2 5/6] KVM: SVM: Inject MCEs when restricted injection is active

Hello

On Tue, Sep 10, 2024 at 2:06 PM Melody Wang <huibo.wang@....com> wrote:

> @@ -5153,7 +5160,7 @@ void sev_snp_cancel_injection(struct kvm_vcpu *vcpu)
>
>         /*
>          * KVM only injects a single event each time (prepare_hv_injection),
> -        * so when events.nmi is true, the vector will be zero
> +        * so when events.nmi is true, the mce and vector will be zero
>          */

This comment seems ambiguous, and in the following code,
events.nmi/mce/vector appears to be able to be true simultaneously,
rather than being mutually exclusive.


>         if (hvdb->events.vector)
>                 svm->vmcb->control.event_inj |= hvdb->events.vector |
> @@ -5162,6 +5169,9 @@ void sev_snp_cancel_injection(struct kvm_vcpu *vcpu)
>         if (hvdb->events.nmi)
>                 svm->vmcb->control.event_inj |= SVM_EVTINJ_TYPE_NMI;
>
> +       if (hvdb->events.mce)
> +               svm->vmcb->control.event_inj |= MC_VECTOR | SVM_EVTINJ_TYPE_EXEPT;