linux-kernel - Re: [PATCH] bus: ts-nbus: Fix an error handling path in ts_nbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jquslj55xt7febemfgu4dinvok77dgpi4h3pqcxgraepioog3e@h2xfsnypdzku>
Date: Mon, 23 Sep 2024 00:06:07 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Sebastien Bourdelin <sebastien.bourdelin@...oirfairelinux.com>, Arnd Bergmann <arnd@...db.de>, Sean Young <sean@...s.org>, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] bus: ts-nbus: Fix an error handling path in
 ts_nbus_probe()

On Sun, Sep 22, 2024 at 03:32:44PM +0200, Christophe JAILLET wrote:
> Le 16/03/2024 à 17:31, Christophe JAILLET a écrit :
> > If of_platform_populate() fails, we must shutdown the FPGA, as already done
> > in the remove function.
> > 
> > Fixes: 5b143d2a6ede ("bus: add driver for the Technologic Systems NBUS")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> > ---
> > Compile tested only.
> > 
> > This patch is speculative and based on the output of one of my scripts that
> > tries to spot calls in .remove function that are not also in the error
> > handling path of the probe. I'm not familiar with the pwm_ API.
> > 
> > I don't think that the locking in the remove function is needed here.
> > 
> > Review with care.
> > ---
> 
> I sent this patch a few months ago, but it never got any feed-back.

The patch looks right. I don't know how the ts_nbus works, but I'd hope
that at the moment ts_nbus_remove() is called, there are no more devices
on that bus that rely on the PWM being on. In that case the locking in
ts_nbus_remove() could be dropped, too.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)