linux-kernel - Re: [PATCH 5/5] arm64: dts: imx8qm: enable dsp node for rproc usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1652f001-742c-4ef0-abee-c9645a3ae63f@gmail.com>
Date: Mon, 23 Sep 2024 02:15:59 +0300
From: Laurentiu Mihalcea <laurentiumihalcea111@...il.com>
To: Frank Li <Frank.li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Daniel Baluta
 <daniel.baluta@....com>, Shengjiu Wang <shengjiu.wang@....com>,
 Iuliana Prodan <iuliana.prodan@....com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] arm64: dts: imx8qm: enable dsp node for rproc usage



On 9/18/2024 10:00 PM, Frank Li wrote:
> On Wed, Sep 18, 2024 at 02:21:17PM -0400, Laurentiu Mihalcea wrote:
>> From: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
>>
>> Set the status of the dsp node to "okay" and assign
>> its reserved memory regions.
> wrap at 75 chars.
>
> Add dsp node and related reserved memory regions.
>
> Frank
>
>> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
>> ---
>>  arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 27 ++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
>> index 62203eed6a6c..7ee69ce7b193 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
>> @@ -92,6 +92,27 @@ vdevbuffer: memory@...00000 {
>>  			reg = <0 0x90400000 0 0x100000>;
>>  			no-map;
>>  		};
>> +
>> +		dsp_reserved: dsp@...00000 {
>> +			reg = <0 0x92400000 0 0x1000000>;
>> +			no-map;
>> +		};
>> +
>> +		dsp_vdev0vring0: vdev0vring0@...f0000 {
> 'vdev0vring0' should be genernal name, such as 'memory'

Driver expects reserved memory node names to have a certain format.
If possible and if too problematic I'd rather have this fixed in a separate patch series.

>
>> +			reg = <0 0x942f0000 0 0x8000>;
>> +			no-map;
>> +		};
>> +
>> +		dsp_vdev0vring1: vdev0vring1@...f8000 {
>> +			reg = <0 0x942f8000 0 0x8000>;
>> +			no-map;
>> +		};
>> +
>> +		dsp_vdev0buffer: vdev0buffer@...00000 {
>> +			compatible = "shared-dma-pool";
>> +			reg = <0 0x94300000 0 0x100000>;
>> +			no-map;
>> +		};
>>  	};
>>
>>  	lvds_backlight0: backlight-lvds0 {
>> @@ -640,6 +661,12 @@ &sai7 {
>>  	status = "okay";
>>  };
>>
>> +&vpu_dsp {
>> +	memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>,
>> +			<&dsp_vdev0vring1>, <&dsp_reserved>;
>> +	status = "okay";
>> +};
>> +
>>  &iomuxc {
>>  	pinctrl-names = "default";
>>  	pinctrl-0 = <&pinctrl_hog>;
>> --
>> 2.34.1
>>