linux-kernel - Re: [PATCH 4/5] arm64: dts: imx8qm: add node for VPU dsp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d02ea50c-249a-4221-8884-cd6674075184@gmail.com>
Date: Mon, 23 Sep 2024 02:19:16 +0300
From: Laurentiu Mihalcea <laurentiumihalcea111@...il.com>
To: Frank Li <Frank.li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Daniel Baluta
 <daniel.baluta@....com>, Shengjiu Wang <shengjiu.wang@....com>,
 Iuliana Prodan <iuliana.prodan@....com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] arm64: dts: imx8qm: add node for VPU dsp



On 9/18/2024 9:57 PM, Frank Li wrote:
> On Wed, Sep 18, 2024 at 02:21:16PM -0400, Laurentiu Mihalcea wrote:
>> From: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
>>
>> Add DT node for i.MX8QM's DSP, which is found in
>> the VPU subsystem.
>>
>> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
>> ---
>>  arch/arm64/boot/dts/freescale/imx8qm.dtsi | 27 +++++++++++++++++++++++
> why not add a file imx8qm-ss-vpu.dtsi to keep consistent with others.

Don't see much value in doing so right now. It's just two extra nodes (should stay that way AFAICT).

>
> Frank
>
>>  1 file changed, 27 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>> index f8b577ebdbef..ae0165a44dcd 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>> @@ -581,6 +581,33 @@ mipi_pll_div2_clk: clock-controller-mipi-div2-pll {
>>  		clock-output-names = "mipi_pll_div2_clk";
>>  	};
>>
>> +	vpu_subsys_dsp: bus@...00000 {
>> +		compatible = "simple-bus";
>> +		#address-cells = <1>;
>> +		#size-cells = <1>;
>> +		ranges = <0x55000000 0x0 0x55000000 0x1000000>;
>> +
>> +		vpu_dsp: dsp@...e8000 {
>> +			compatible = "fsl,imx8qm-hifi4";
>> +			reg = <0x556e8000 0x88000>;
>> +			clocks = <&clk_dummy>,
>> +				 <&clk_dummy>,
>> +				 <&clk_dummy>;
>> +			clock-names = "ipg", "ocram", "core";
>> +			power-domains = <&pd IMX_SC_R_MU_13B>,
>> +					<&pd IMX_SC_R_DSP>,
>> +					<&pd IMX_SC_R_DSP_RAM>,
>> +					<&pd IMX_SC_R_IRQSTR_DSP>,
>> +					<&pd IMX_SC_R_MU_2A>;
>> +			mbox-names = "tx", "rx", "rxdb";
>> +			mboxes = <&lsio_mu13 0 0>,
>> +				 <&lsio_mu13 1 0>,
>> +				 <&lsio_mu13 3 0>;
>> +			firmware-name = "imx/dsp/hifi4.bin";
>> +			status = "disabled";
>> +		};
>> +	};
>> +
>>  	/* sorted in register address */
>>  	#include "imx8-ss-cm41.dtsi"
>>  	#include "imx8-ss-audio.dtsi"
>> --
>> 2.34.1
>>