linux-kernel - Re: [PATCH 1/3] dt-bindings: display: rockchip-vop: Split rk3288-vop into big and lit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9b04df3-18f7-416e-a973-422bcf341d3a@kernel.org>
Date: Sun, 22 Sep 2024 10:12:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jonas Karlman <jonas@...boo.se>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Sandy Huang <hjc@...k-chips.com>,
 Heiko Stuebner <heiko@...ech.de>, Andy Yan <andy.yan@...k-chips.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: display: rockchip-vop: Split rk3288-vop
 into big and lit

On 22/09/2024 00:20, Jonas Karlman wrote:
> The Rockchip RK3288 SoC contain two different Visual Output Processor
> (VOP) blocks, VOP_BIG and VOP_LIT. The VOP blocks support different max
> output resolution, 3840x2160 and 2560x1600.
> 
> Add compatible to differentiate between the two VOP blocks.
> 
> Signed-off-by: Jonas Karlman <jonas@...boo.se>
> ---
>  .../display/rockchip/rockchip-vop.yaml        | 36 +++++++++++--------
>  1 file changed, 21 insertions(+), 15 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml
> index b339b7e708c6..ce4169b030af 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml
> @@ -17,21 +17,27 @@ maintainers:
>  
>  properties:
>    compatible:
> -    enum:
> -      - rockchip,px30-vop-big
> -      - rockchip,px30-vop-lit
> -      - rockchip,rk3036-vop
> -      - rockchip,rk3066-vop
> -      - rockchip,rk3126-vop
> -      - rockchip,rk3188-vop
> -      - rockchip,rk3228-vop
> -      - rockchip,rk3288-vop
> -      - rockchip,rk3328-vop
> -      - rockchip,rk3366-vop
> -      - rockchip,rk3368-vop
> -      - rockchip,rk3399-vop-big
> -      - rockchip,rk3399-vop-lit
> -      - rockchip,rv1126-vop
> +    oneOf:
> +      - items:
> +          - enum:
> +              - rockchip,rk3288-vop-big
> +              - rockchip,rk3288-vop-lit
> +          - const: rockchip,rk3288-vop
> +      - enum:
> +          - rockchip,px30-vop-big
> +          - rockchip,px30-vop-lit
> +          - rockchip,rk3036-vop
> +          - rockchip,rk3066-vop
> +          - rockchip,rk3126-vop
> +          - rockchip,rk3188-vop
> +          - rockchip,rk3228-vop
> +          - rockchip,rk3288-vop

I think this one should be dropped. You will update all in-kernel users,
so it won't be needed here and all other projects should probably follow up.

Best regards,
Krzysztof