linux-kernel - RE: [PATCH] gpio: davinci: fix lazy disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2c39198c3ac450e8fa332cfc4d15fbc@ti.com>
Date: Mon, 23 Sep 2024 10:06:02 +0000
From: "J, KEERTHY" <j-keerthy@...com>
To: Francesco Dolcini <francesco@...cini.it>,
        Bartosz Golaszewski
	<brgl@...ev.pl>
CC: Parth Pancholi <parth105105@...il.com>,
        Linus Walleij
	<linus.walleij@...aro.org>,
        Emanuele Ghidoli <emanuele.ghidoli@...adex.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Parth Pancholi
	<parth.pancholi@...adex.com>,
        "stable@...r.kernel.org"
	<stable@...r.kernel.org>
Subject: RE: [PATCH] gpio: davinci: fix lazy disable



-----Original Message-----
From: Francesco Dolcini <francesco@...cini.it> 
Sent: Monday, September 23, 2024 3:10 PM
To: J, KEERTHY <j-keerthy@...com>; Bartosz Golaszewski <brgl@...ev.pl>
Cc: Parth Pancholi <parth105105@...il.com>; Linus Walleij <linus.walleij@...aro.org>; Emanuele Ghidoli <emanuele.ghidoli@...adex.com>; linux-gpio@...r.kernel.org; linux-kernel@...r.kernel.org; Parth Pancholi <parth.pancholi@...adex.com>; stable@...r.kernel.org
Subject: Re: [PATCH] gpio: davinci: fix lazy disable

Hello Keerthy,

On Mon, Sep 02, 2024 at 02:08:30PM +0200, Bartosz Golaszewski wrote:
> On Wed, Aug 28, 2024 at 3:32 PM Parth Pancholi <parth105105@...il.com> wrote:
> >
> > From: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
> >
> > On a few platforms such as TI's AM69 device, disable_irq()
> > fails to keep track of the interrupts that happen between
> > disable_irq() and enable_irq() and those interrupts are missed.
> > Use the ->irq_unmask() and ->irq_mask() methods instead
> > of ->irq_enable() and ->irq_disable() to correctly keep track of
> > edges when disable_irq is called.
> > This solves the issue of disable_irq() not working as expected
> > on such platforms.
> >
> > Fixes: 23265442b02b ("ARM: davinci: irq_data conversion.")
> > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
> > Signed-off-by: Parth Pancholi <parth.pancholi@...adex.com>
> > Cc: stable@...r.kernel.org
> > ---
> 
> It looks good to me but I'd like to have an Ack from Keerthy on this.

Keerthy, just a gentle ping on this, can you help?

> Acked-by: Keerthy <j-keerthy@...com>

Francesco