linux-kernel - Re: [PATCH] gpio: davinci: fix lazy disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172769721870.54897.1079647441666615985.b4-ty@linaro.org>
Date: Mon, 30 Sep 2024 13:54:44 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Keerthy <j-keerthy@...com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Parth Pancholi <parth105105@...il.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Emanuele Ghidoli <emanuele.ghidoli@...adex.com>,
	linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Parth Pancholi <parth.pancholi@...adex.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH] gpio: davinci: fix lazy disable

From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>


On Wed, 28 Aug 2024 15:32:07 +0200, Parth Pancholi wrote:
> On a few platforms such as TI's AM69 device, disable_irq()
> fails to keep track of the interrupts that happen between
> disable_irq() and enable_irq() and those interrupts are missed.
> Use the ->irq_unmask() and ->irq_mask() methods instead
> of ->irq_enable() and ->irq_disable() to correctly keep track of
> edges when disable_irq is called.
> This solves the issue of disable_irq() not working as expected
> on such platforms.
> 
> [...]

A couple hints:

Keerthy: Don't quote your tags as b4 will not pick it up.
Parth: Don't wrap the commit message lines too eagerly as it actually makes
it less readable.

Applied for fixes, thanks!

[1/1] gpio: davinci: fix lazy disable
      commit: 3360d41f4ac490282fddc3ccc0b58679aa5c065d

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>