linux-kernel - Re: [PATCH] damon: access_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240923163608.552593-1-sj@kernel.org>
Date: Mon, 23 Sep 2024 09:36:07 -0700
From: SeongJae Park <sj@...nel.org>
To: Ba Jing <bajing@...s.chinamobile.com>
Cc: SeongJae Park <sj@...nel.org>,
	shuah@...nel.org,
	damon@...ts.linux.dev,
	linux-mm@...ck.org,
	linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] damon: access_memory_even: remove unused variables

Hi Ba,

On Tue,  3 Sep 2024 11:43:00 +0800 Ba Jing <bajing@...s.chinamobile.com> wrote:

> These variables are never referenced in the code, just remove it.

Nice finding, thank you!

I'd prefer having 'selftests/damon/access_memory_even: ' as the commit subject
prefix.

> 
> Signed-off-by: Ba Jing <bajing@...s.chinamobile.com>

Other than the above trivial nitpick,

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ

> ---
>  tools/testing/selftests/damon/access_memory_even.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c
> index 3be121487432..a9f4e9aaf3a9 100644
> --- a/tools/testing/selftests/damon/access_memory_even.c
> +++ b/tools/testing/selftests/damon/access_memory_even.c
> @@ -14,10 +14,8 @@
>  int main(int argc, char *argv[])
>  {
>  	char **regions;
> -	clock_t start_clock;
>  	int nr_regions;
>  	int sz_region;
> -	int access_time_ms;
>  	int i;
>  
>  	if (argc != 3) {
> -- 
> 2.33.0