linux-kernel - Re: [PATCH] damon: access_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e71e7e2-5b69-488d-b3fc-e547d6b4b042@linuxfoundation.org>
Date: Mon, 23 Sep 2024 10:44:43 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Ba Jing <bajing@...s.chinamobile.com>, sj@...nel.org
Cc: shuah@...nel.org, damon@...ts.linux.dev, linux-mm@...ck.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] damon: access_memory_even: remove unused variables

On 9/2/24 21:43, Ba Jing wrote:
> These variables are never referenced in the code, just remove it.

remove them?

Add details on how you found this problem in the commit log.
Send v2 with these changes.

> 
> Signed-off-by: Ba Jing <bajing@...s.chinamobile.com>
> ---
>   tools/testing/selftests/damon/access_memory_even.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c
> index 3be121487432..a9f4e9aaf3a9 100644
> --- a/tools/testing/selftests/damon/access_memory_even.c
> +++ b/tools/testing/selftests/damon/access_memory_even.c
> @@ -14,10 +14,8 @@
>   int main(int argc, char *argv[])
>   {
>   	char **regions;
> -	clock_t start_clock;
>   	int nr_regions;
>   	int sz_region;
> -	int access_time_ms;
>   	int i;
>   
>   	if (argc != 3) {

With these changes:

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah