linux-kernel - Re: [PATCH v2] net: wwan: qcom_bam_dmux: Fix missing pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95bdde5a-b09d-48ad-98a2-2bdeffc7a567@gmail.com>
Date: Tue, 24 Sep 2024 20:16:27 +0300
From: Sergey Ryazanov <ryazanov.s.a@...il.com>
To: Jinjie Ruan <ruanjinjie@...wei.com>, stephan@...hold.net,
 loic.poulain@...aro.org, johannes@...solutions.net, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: wwan: qcom_bam_dmux: Fix missing
 pm_runtime_disable()

On 23.09.2024 14:57, Jinjie Ruan wrote:
> It's important to undo pm_runtime_use_autosuspend() with
> pm_runtime_dont_use_autosuspend() at driver exit time.
> 
> But the pm_runtime_disable() and pm_runtime_dont_use_autosuspend()
> is missing in the error path for bam_dmux_probe(). So add it.
> 
> Found by code review. Compile-tested only.
> 
> Fixes: 21a0ffd9b38c ("net: wwan: Add Qualcomm BAM-DMUX WWAN network driver")
> Suggested-by: Stephan Gerhold <stephan.gerhold@...aro.org>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>

Reviewed-by: Sergey Ryazanov <ryazanov.s.a@...il.com>