[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKEwX=ML+8uPUm7fMRKJcvqrctH9qf0tYha0TLr0JxzFSZ-z0w@mail.gmail.com>
Date: Tue, 24 Sep 2024 10:16:33 -0700
From: Nhat Pham <nphamcs@...il.com>
To: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, hannes@...xchg.org,
yosryahmed@...gle.com, chengming.zhou@...ux.dev, usamaarif642@...il.com,
shakeel.butt@...ux.dev, ryan.roberts@....com, ying.huang@...el.com,
21cnbao@...il.com, akpm@...ux-foundation.org, nanhai.zou@...el.com,
wajdi.k.feghali@...el.com, vinodh.gopal@...el.com
Subject: Re: [PATCH v7 3/8] mm: zswap: Refactor code to store an entry in
zswap xarray.
On Mon, Sep 23, 2024 at 6:17 PM Kanchana P Sridhar
<kanchana.p.sridhar@...el.com> wrote:
>
> Added a new procedure zswap_store_entry() that refactors the code
> currently in zswap_store() to store an entry in the zswap xarray.
> This will allow us to call this procedure for each storing the swap
> offset of each page in an mTHP in the xarray, as part of zswap_store()
> supporting mTHP.
>
> Also, made a minor edit in the comments for 'struct zswap_entry' to delete
> the description of the 'value' member that was deleted in commit
> 20a5532ffa53d6ecf41ded920a7b0ff9c65a7dcf ("mm: remove code to handle
> same filled pages").
nit: This probably should be a separate patch...
>
> Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
Otherwise, LGTM :)
Reviewed-by: Nhat Pham <nphamcs@...il.com>
Powered by blists - more mailing lists