linux-kernel - Re: [PATCHv2] mm: do not export const kfree and kstrdup variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvJkC_3cov1rfY0V@infradead.org>
Date: Tue, 24 Sep 2024 00:02:35 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Andrey Skvortsov <andrej.skvortzov@...il.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] mm: do not export const kfree and kstrdup variants

On Tue, Sep 24, 2024 at 03:56:53PM +0900, Sergey Senozhatsky wrote:
> Totally agree with all the points, I haven't looked at how
> popular that API was before sending out the patch.  Is there
> some sort of "built time const" but for strings that we, perhaps,
> can add to kfree_const() (and make kfree_const() always inline)?
> So that we can turn this
> 
> 	str = "boom";
> 	...
> 	kfree_const(str);
> 
> into a safe scenario for modules.

Not sure, but even then the API would be horrible as it still would
not work for constants in other modules than the one calling it.