linux-kernel - Re: [PATCH v3 10/29] media: iris: implement power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <779ec517-9d3f-bc3d-83aa-72cb01e44106@quicinc.com>
Date: Tue, 24 Sep 2024 14:08:05 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Bryan O'Donoghue
	<bryan.odonoghue@...aro.org>,
        Vikash Garodia <quic_vgarodia@...cinc.com>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Mauro Carvalho Chehab
	<mchehab@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Philipp Zabel
	<p.zabel@...gutronix.de>
CC: <linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 10/29] media: iris: implement power management



On 9/5/2024 7:16 PM, Krzysztof Kozlowski wrote:
> On 05/09/2024 15:23, Bryan O'Donoghue wrote:
>> On 27/08/2024 11:05, Dikshita Agarwal via B4 Relay wrote:
>>> From: Dikshita Agarwal <quic_dikshita@...cinc.com>
>>>
>>> Implement runtime power management for iris including
>>> platform specific power on/off sequence.
>>>
>>> Signed-off-by: Dikshita Agarwal <quic_dikshita@...cinc.com>
>>
>>> +int iris_hfi_pm_suspend(struct iris_core *core)
>>> +{
>>> +	int ret;
>>> +
>>> +	if (!mutex_is_locked(&core->lock))
>>> +		return -EINVAL;
>>> +
>>> +	if (core->state != IRIS_CORE_INIT)
>>> +		return -EINVAL;
>>
>> Reiterating a previous point
>>
>> Are these checks realistic or defensive coding ?
> 
> Well, this one:
> 
> if (!mutex_is_locked(&core->lock))
> 
> is clear bug or someone is reinventing lockdep.
> 
Sure, will remove this check.
>>> +
>>> +	if (!core->power_enabled) {
>>> +		dev_err(core->dev, "power not enabled\n");
>>> +		return 0;
>>> +	}
>>
>> Similarly is this a real check an error that can happen and if so how ?
> 
> And here re-inventing runtime PM.
> 
I understand the concern, will remove this check as well.
> Best regards,
> Krzysztof
> 
>