linux-kernel - Re: [PATCH v3 2/4] arm64: dts: imx: Add imx8mp-iota2-lumpy board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8243ef43-cb5b-4aef-88cd-7aeffa9eeff6@ysoft.com>
Date: Tue, 24 Sep 2024 11:06:04 +0200
From: Michal Vokáč <michal.vokac@...ft.com>
To: Marco Felsch <m.felsch@...gutronix.de>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Shawn Guo <shawnguo@...nel.org>, Petr Benes <petr.benes@...ft.com>,
 devicetree@...r.kernel.org, linux-usb@...r.kernel.org,
 Michael Walle <mwalle@...nel.org>, imx@...ts.linux.dev,
 Alexander Stein <alexander.stein@...tq-group.com>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Mathieu Othacehe <m.othacehe@...il.com>,
 Hugo Villeneuve <hvilleneuve@...onoff.com>, linux-kernel@...r.kernel.org,
 Hiago De Franco <hiago.franco@...adex.com>,
 Herburger <gregor.herburger@...tq-group.com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Joao Paulo Goncalves <joao.goncalves@...adex.com>,
 Fabio Estevam <festevam@...il.com>, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 2/4] arm64: dts: imx: Add imx8mp-iota2-lumpy board

On 24. 09. 24 9:16, Marco Felsch wrote:
> Hi Michael,
> 
> thanks for the patch, please see below some notes but nothing crucial.
> 
>> +
>> +&i2c1 {
>> +	clock-frequency = <400000>;
>> +	pinctrl-0 = <&pinctrl_i2c1>;
>> +	pinctrl-names = "default";
>> +	status = "okay";
>> +
>> +	pmic@25 {
>> +		compatible = "nxp,pca9450c";
>> +		reg = <0x25>;
>> +		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
>> +		interrupt-parent = <&gpio1>;
>> +		pinctrl-0 = <&pinctrl_pmic>;
>> +		pinctrl-names = "default";
>> +
>> +		regulators {
>> +			BUCK1 {
>> +				regulator-always-on;
> 
> All your PMIC rails are marked as regulator-always-on. I didn't expect
> this from a (battery backed) IOT platform.

These are correct. I is not a battery backed device. It operates on 12V
from wall power adapter. It is more like an Ethernet router/edge device
for a B2B solution.

>> +				regulator-boot-on;
>> +				regulator-max-microvolt = <1000000>;
>> +				regulator-min-microvolt = <720000>;
>> +				regulator-name = "BUCK1";
>> +				regulator-ramp-delay = <3125>;
>> +			};
>> +


>> +
>> +&iomuxc {
> 
> Albeit we do sort the node names alphabetical we put the iomuxc at the
> very end at least for the i.MX platforms. Maybe this is something
> Frank's tool should be aware of in the future :)

I am used to do it the way you say. I just accepted Frank's comment
and that it is maybe a new standard to sort all nodes strictly alphabetically.

OK, I will move the iomuxc node back to the end as usual.

>> +&usdhc3 {
>> +	assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
>> +	assigned-clock-rates = <400000000>;
>> +	bus-width = <8>;
>> +	non-removable;
> 
> Please move the bus-width and non-removeable properties below the
> pinctrl-* properties.

OK.

>> +	pinctrl-0 = <&pinctrl_usdhc3>;
>> +	pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
>> +	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
>> +	pinctrl-names = "default", "state_100mhz", "state_200mhz";
>> +	status = "okay";
>> +};
>> +
>> +&wdog1 {
>> +	fsl,ext-reset-output;
> 
> This property should be put below the pinctrl-* properties.

OK.

Thank you for the review,
Michal

>> +	pinctrl-0 = <&pinctrl_wdog>;
>> +	pinctrl-names = "default";
>> +	status = "okay";
>> +};